Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x]Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… #3452

Merged
merged 3 commits into from
Mar 10, 2023
Merged

[Manual backport 2.x]Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… #3452

merged 3 commits into from
Mar 10, 2023

Conversation

kristenTian
Copy link
Contributor

@kristenTian kristenTian commented Feb 17, 2023 •
edited by ananzh
Loading

Description

Resolved Issue

#765

Backport PR

#3051
#3308

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kristenTian kristenTian requested a review from a team as a code owner February 17, 2023 20:19
@kristenTian kristenTian changed the title Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… [Manual backport 2.x]Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… Feb 17, 2023
tmarkley and others added 2 commits February 17, 2023 12:53
@tmarkley @ananzh @kristenTian
Updates NOTICE file, adds validation to GitHub CI (opensearch-project…
2d224de 
…#3051)

* Aligns NOTICE with rules outlined in
opensearch-project/.github#21.
* Adds NOTICE validation to the build and test workflow.
* Fixes product name discrepancies between repository NOTICE file and
the generated NOTICE file for the build.
* Skips template-izing the build and test workflow since that's being
worked on in opensearch-project#2991.

Resolves opensearch-project#765

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
@tmarkley @zhongnansu
@AMoo-Miki @kristenTian
Corrects NOTICE file copyright date range (opensearch-project#3308)
a5cf6e9 
* Corrects NOTICE file copyright date range

* Follow-up on opensearch-project#3051

Resolves opensearch-project#765

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Miki <amoo_miki@yahoo.com>

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
@kristenTian kristenTian added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023 •
edited
Loading

Codecov Report

Merging #3452 (1ae2644) into 2.x (723d077) will increase coverage by 0.00%.
The diff coverage is 12.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3452   +/-   ##
=======================================
  Coverage   66.48%   66.49%           
=======================================
  Files        3203     3203           
  Lines       61397    61392    -5     
  Branches     9453     9453           
=======================================
- Hits        40821    40820    -1     
+ Misses      18315    18310    -5     
- Partials     2261     2262    +1
Flag Coverage Δ
Linux 66.49% <12.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/notice/generate_notice_from_source.ts 14.28% <12.50%> (+5.19%) ⬆️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ananzh
ananzh approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuarrrr
joshuarrrr previously requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we intend to change the copyright start date? Blocking until we can confirm.

NOTICE.txt Show resolved Hide resolved
@joshuarrrr joshuarrrr added v2.7.0 and removed v2.6.0 labels Feb 18, 2023
@ashwin-pc ashwin-pc self-assigned this Mar 7, 2023
@joshuarrrr joshuarrrr dismissed their stale review March 10, 2023 21:55

question answered

@joshuarrrr joshuarrrr merged commit 6d802d4 into opensearch-project:2.x Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc left review comments

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@ananzh ananzh ananzh approved these changes

Assignees

@ashwin-pc ashwin-pc

Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kristenTian @codecov-commenter @joshuarrrr @ashwin-pc @ananzh @tmarkley