Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Manual] Gets rid of github-checks-reporter (#3126) #3178

Conversation

manasvinibs
Copy link
Member

Signed-off-by: Miki miki@amazon.com
(cherry picked from commit 5116f16)
Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs requested a review from a team as a code owner January 5, 2023 01:57
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 5, 2023
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #3178 (3f8656a) into 2.x (62d36ff) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #3178      +/-   ##
==========================================
+ Coverage   66.61%   66.65%   +0.04%     
==========================================
  Files        3219     3219              
  Lines       61531    61531              
  Branches     9431     9431              
==========================================
+ Hits        40986    41014      +28     
+ Misses      18303    18278      -25     
+ Partials     2242     2239       -3     
Flag Coverage Δ
Linux 66.59% <ø> (-0.02%) ⬇️
Windows 66.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (-1.32%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (-0.89%) ⬇️
...ared/static/forms/hook_form_lib/hooks/use_field.ts 66.66% <0.00%> (+0.96%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 85.36% <0.00%> (+34.14%) ⬆️
src/setup_node_env/harden/child_process.js 76.92% <0.00%> (+38.46%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AMoo-Miki
AMoo-Miki previously approved these changes Jan 5, 2023
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lockfile looks good

Can we try a yarn osd bootstrap please?

@manasvinibs
Copy link
Member Author

lockfile looks good

Can we try a yarn osd bootstrap please?

Yes on doing osd bootstrap found lodash@^4.0.0 and lodash@~4.17.10 got updated in the yarn.lock file which is missing in this PR. Updated the PR with correct lock file.

AMoo-Miki
AMoo-Miki previously approved these changes Jan 5, 2023
abbyhu2000
abbyhu2000 previously approved these changes Jan 5, 2023
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 5116f16)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
@manasvinibs manasvinibs merged commit 0c56474 into opensearch-project:2.x Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants