Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id #2635

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

abbyhu2000
Copy link
Member

Signed-off-by: abbyhu2000 abigailhu2000@gmail.com

Description

Rename wizard to visBuilder in i18n id and formatted message id

Issues Resolved

resolves part of #1706

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 changed the title Rename wizard to visBuilder in i18n id and formatted message id [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id Oct 20, 2022
@abbyhu2000 abbyhu2000 self-assigned this Oct 20, 2022
@abbyhu2000 abbyhu2000 added vis builder v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 20, 2022
@abbyhu2000 abbyhu2000 marked this pull request as ready for review October 20, 2022 18:02
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner October 20, 2022 18:02
@codecov-commenter
Copy link

Codecov Report

Merging #2635 (ebecc5d) into main (33aed0a) will increase coverage by 0.00%.
The diff coverage is 25.00%.

❗ Current head ebecc5d differs from pull request most recent head d08fa75. Consider uploading reports for the commit d08fa75 to get more accurate results

@@           Coverage Diff           @@
##             main    #2635   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3207     3207           
  Lines       61137    61137           
  Branches     9313     9313           
=======================================
+ Hits        40849    40851    +2     
+ Misses      18057    18056    -1     
+ Partials     2231     2230    -1     
Impacted Files Coverage Δ
...blic/application/components/data_source_select.tsx 9.09% <ø> (ø)
...c/application/components/data_tab/field_search.tsx 0.00% <0.00%> (ø)
...ublic/application/components/experimental_info.tsx 66.66% <ø> (ø)
...uilder/public/application/components/right_nav.tsx 13.33% <ø> (ø)
...er/public/application/utils/get_top_nav_config.tsx 56.52% <ø> (ø)
...ilder/public/application/utils/use/use_can_save.ts 11.11% <0.00%> (ø)
...ilder/public/embeddable/disabled_visualization.tsx 0.00% <ø> (ø)
...blic/embeddable/vis_builder_embeddable_factory.tsx 11.11% <0.00%> (ø)
src/plugins/vis_builder/public/plugin.ts 27.58% <ø> (ø)
...is_builder/public/application/utils/breadcrumbs.ts 16.66% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 merged commit 8d5e504 into opensearch-project:main Oct 20, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2635-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d5e504041ce808c0c897a32485de5f8eed30d2a
# Push it to GitHub
git push --set-upstream origin backport/backport-2635-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2635-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8d5e504)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8d5e504)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kristenTian pushed a commit that referenced this pull request Nov 2, 2022
… (#2744)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8d5e504)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kristenTian pushed a commit that referenced this pull request Nov 2, 2022
… (#2745)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8d5e504)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…search-project#2635)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
…search-project#2635)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x rename v2.4.0 'Issues and PRs related to version v2.4.0' vis builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants