[MD] Address UX comments for index pattern pages #2505

kristenTian · 2022-10-05T00:37:32Z

Signed-off-by: Kristen Tian tyarong@amazon.com

Description

Address UX comments for index pattern pages

Switch from SaveObjectFinder to EUISelectable

Add data source title to step index pattern

Error toast while fetching existing data sources

Issues Resolved

UX
opensearch-project/ux#42

Check List

Commits are signed per the DCO using --signoff

...ponents/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx

codecov-commenter · 2022-10-05T01:26:15Z

Codecov Report

Merging #2505 (8151000) into main (ca718a3) will decrease coverage by 0.02%.
The diff coverage is 38.63%.

@@            Coverage Diff             @@
##             main    #2505      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.03%     
==========================================
  Files        3201     3201              
  Lines       60913    60943      +30     
  Branches     9254     9258       +4     
==========================================
+ Hits        40683    40689       +6     
- Misses      18018    18039      +21     
- Partials     2212     2215       +3

Impacted Files	Coverage Δ
...ndex_pattern_management/public/components/utils.ts	`40.90% <0.00%> (-23.38%)`	⬇️
...ents/step_data_source/components/header/header.tsx	`61.11% <41.66%> (-28.89%)`	⬇️
...d/components/step_data_source/step_data_source.tsx	`66.66% <50.00%> (ø)`
...ts/step_index_pattern/components/header/header.tsx	`63.63% <55.55%> (+3.63%)`	⬆️
...mponents/step_index_pattern/step_index_pattern.tsx	`85.71% <100.00%> (ø)`
...ic/application/models/sense_editor/sense_editor.ts	`64.00% <0.00%> (-0.89%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

KrooshalUX · 2022-10-05T19:18:52Z

@kristenTian Can you please provide a full screen screenshot? I am not understanding the context of the radio button. Please also see : opensearch-project/ux#40

kristenTian · 2022-10-05T21:47:43Z

@kristenTian Can you please provide a full screen screenshot? I am not understanding the context of the radio button. Please also see : opensearch-project/ux#40

Updated

Signed-off-by: Kristen Tian <tyarong@amazon.com>

AMoo-Miki · 2022-10-06T02:29:08Z

...ponents/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx

+        if (fetchedDataSources?.length) {
+          setDataSources(fetchedDataSources);
+        }


Is it guarantied that the backend will throw if no data sources are available? If not, shouldn't we show something when no data sources are returned?

I don't think backend will throw. Current behavior is the drop down will show as empty. in later phases, UX designed an empty state to show.

AMoo-Miki · 2022-10-06T02:33:07Z

src/plugins/index_pattern_management/public/components/utils.ts

+      .find<DataSourceAttributes>({
+        type: 'data-source',
+        fields: ['title', 'type'],
+        perPage: 10000,


Is there any precedence for this 10000? Does it need to exist? Does it have to be hardcoded? Can it be configurable? Can it be read from a common config?

it is referenced from the how other places are using this method in the repo:

OpenSearch-Dashboards/src/plugins/data_source_management/public/components/utils.ts

Line 14 in 890a4b6

perPage: 10000,

and

OpenSearch-Dashboards/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx

Line 157 in 890a4b6

perPage: 10000,

I am also not a fan of this approach. We can add an action item to add pagination supported client wrapper as an action item?

10000 is a commonly used value in the OpenSearch/osd world, it's the default max OS search hits, see reference here. Tho it's not a good practice to use hardcode, but sadly this value is used everywhere in the codebase. My suggestion is we can add an OSD global config such as savedObjects.PaginationSize, it could be tracked as a new issue

Good to know 😊

opensearch-trigger-bot · 2022-10-06T18:27:44Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2505-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4095e123d77182bed213fedf41be00ccaffd34a7
# Push it to GitHub
git push --set-upstream origin backport/backport-2505-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2505-to-2.x.

opensearch-trigger-bot · 2022-10-06T18:46:39Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2505-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4095e123d77182bed213fedf41be00ccaffd34a7
# Push it to GitHub
git push --set-upstream origin backport/backport-2505-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2505-to-2.x.

…2505) Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 4095e12)

Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 4095e12)

…2505) (opensearch-project#2525) Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 4095e12)

…2505) Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

kristenTian requested a review from a team as a code owner October 5, 2022 00:37

kristenTian added the multiple datasource multiple datasource project label Oct 5, 2022

kristenTian force-pushed the OSD-main branch from facd364 to ecd66a3 Compare October 5, 2022 00:39

kristenTian self-assigned this Oct 5, 2022

kristenTian requested review from AMoo-Miki, zengyan-amazon and KrooshalUX October 5, 2022 00:40

zhongnansu added the backport 2.x label Oct 5, 2022

AMoo-Miki reviewed Oct 5, 2022

View reviewed changes

...ponents/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx Outdated Show resolved Hide resolved

kristenTian force-pushed the OSD-main branch 2 times, most recently from 9b07fb6 to 0caf256 Compare October 5, 2022 03:24

zhongnansu previously approved these changes Oct 5, 2022

View reviewed changes

kristenTian dismissed zhongnansu’s stale review via 5ab977a October 6, 2022 00:14

kristenTian force-pushed the OSD-main branch from 0caf256 to 5ab977a Compare October 6, 2022 00:14

[MD] Address UX comments for index pattern pages

8151000

Signed-off-by: Kristen Tian <tyarong@amazon.com>

kristenTian force-pushed the OSD-main branch from 5ab977a to 8151000 Compare October 6, 2022 01:05

AMoo-Miki approved these changes Oct 6, 2022

View reviewed changes

zengyan-amazon approved these changes Oct 6, 2022

View reviewed changes

kristenTian merged commit 4095e12 into opensearch-project:main Oct 6, 2022

zhongnansu added backport 2.x and removed backport 2.x labels Oct 6, 2022

zhongnansu mentioned this pull request Oct 6, 2022

[Backport 2.x] [MD] Address UX comments for index pattern pages #2525

Merged

kavilla mentioned this pull request Oct 6, 2022

Update index pattern name input box to display Data Source before input box - data source is not editable opensearch-project/ux#42

Closed

kavilla pushed a commit that referenced this pull request Oct 10, 2022

[MD] Address UX comments for index pattern pages (#2505) (#2525)

bebd4bc

Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 4095e12)

AMoo-Miki added enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] Address UX comments for index pattern pages #2505

[MD] Address UX comments for index pattern pages #2505

kristenTian commented Oct 5, 2022 •

edited

Loading

codecov-commenter commented Oct 5, 2022 •

edited

Loading

KrooshalUX commented Oct 5, 2022

kristenTian commented Oct 5, 2022

AMoo-Miki Oct 6, 2022

kristenTian Oct 6, 2022

AMoo-Miki Oct 6, 2022

zhongnansu Oct 6, 2022

kristenTian Oct 6, 2022

zhongnansu Oct 6, 2022 •

edited

Loading

kristenTian Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

[MD] Address UX comments for index pattern pages #2505

[MD] Address UX comments for index pattern pages #2505

Conversation

kristenTian commented Oct 5, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Oct 5, 2022 • edited Loading

Codecov Report

KrooshalUX commented Oct 5, 2022

kristenTian commented Oct 5, 2022

AMoo-Miki Oct 6, 2022

Choose a reason for hiding this comment

kristenTian Oct 6, 2022

Choose a reason for hiding this comment

AMoo-Miki Oct 6, 2022

Choose a reason for hiding this comment

zhongnansu Oct 6, 2022

Choose a reason for hiding this comment

kristenTian Oct 6, 2022

Choose a reason for hiding this comment

zhongnansu Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

kristenTian Oct 6, 2022

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

kristenTian commented Oct 5, 2022 •

edited

Loading

codecov-commenter commented Oct 5, 2022 •

edited

Loading

zhongnansu Oct 6, 2022 •

edited

Loading