Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataSource & dataSourceManagement Readme #2448

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add dataSource & dataSourceManagement Readme #2448

merged 1 commit into from
Oct 4, 2022

Conversation

kristenTian
Copy link
Contributor

@kristenTian kristenTian commented Sep 28, 2022 •
edited
Loading

Signed-off-by: Kristen Tian tyarong@amazon.com

Description

Add dataSource & dataSourceManagement Readme

Issues Resolved

#2436
#2437
#2199
#2158

Check List

  • Commits are signed per the DCO using --signoff

@kristenTian kristenTian requested a review from a team as a code owner September 28, 2022 23:47
@kristenTian kristenTian added the multiple datasource multiple datasource project label Sep 28, 2022
@zhongnansu
Copy link
Member

#2199
#2158
This PR also resolves these 2. Let's try not to have duplicate issues.

@kristenTian kristenTian force-pushed the multiD-rebase6 branch 2 times, most recently from be55af1 to ed76bf7 Compare September 29, 2022 00:07
yibow98
yibow98 reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@yibow98 yibow98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just fix some typos.

@kristenTian
Copy link
Contributor Author

Overall looks good to me. Just fix some typos.

thanks a lot, addressed all

zengyan-amazon
zengyan-amazon reviewed Sep 29, 2022
View reviewed changes
src/plugins/data_source/README.md Outdated Show resolved Hide resolved
src/plugins/data_source/README.md Outdated Show resolved Hide resolved
src/plugins/data_source/README.md Outdated Show resolved Hide resolved
src/plugins/data_source_management/README.md Outdated Show resolved Hide resolved
@zengyan-amazon zengyan-amazon mentioned this pull request Sep 29, 2022
Merged
8 tasks
@noCharger
Copy link
Contributor

Let's also update the CHANGELOG

@kavilla kavilla added backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' labels Sep 29, 2022
@seraphjiang
Copy link
Member

Let's also update the CHANGELOG

+1
a reference

Documentation
README.md for saving index pattern relationship (#2276)
Remove extra typo from README. (#2403)

@kristenTian kristenTian force-pushed the multiD-rebase6 branch 2 times, most recently from c4e72b5 to 38ef966 Compare September 30, 2022 20:26
zengyan-amazon
zengyan-amazon previously approved these changes Sep 30, 2022
View reviewed changes
noCharger
noCharger previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit.

src/plugins/data_source/README.md Outdated Show resolved Hide resolved
zhongnansu
zhongnansu previously approved these changes Oct 4, 2022
View reviewed changes
noCharger
noCharger previously approved these changes Oct 4, 2022
View reviewed changes
@kristenTian kristenTian dismissed stale reviews from noCharger and zhongnansu via aae7cbc October 4, 2022 00:34
@kristenTian
Add dataSource & dataSourceManagement ReadMe
bfc1e8d 
Signed-off-by: Kristen Tian <tyarong@amazon.com>
@kristenTian kristenTian merged commit fb39f7d into opensearch-project:main Oct 4, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2448-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb39f7d4732faad33a23388aa707366db97d3527
# Push it to GitHub
git push --set-upstream origin backport/backport-2448-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2448-to-2.x.

@vagimeli vagimeli mentioned this pull request Oct 4, 2022
Closed
15 tasks
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 5, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
@kristenTian @github-actions
Add dataSource & dataSourceManagement ReadMe (#2448)
5a53628 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fb39f7d)
This was linked to issues Oct 6, 2022
[MD] Documentation for "data_source" plugin #2436
Closed
[MD] Documentation for "data_source_management" plugin #2437
Closed
[MD] Add README for data_source plugin #2199
Closed
[MD] Add doc for feature flag #2158
Closed
kavilla pushed a commit that referenced this pull request Oct 6, 2022
@opensearch-trigger-bot
Add dataSource & dataSourceManagement ReadMe (#2448) (#2518)
22ae8fe 
Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit fb39f7d)
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@kristenTian @sipopo
Add dataSource & dataSourceManagement ReadMe (opensearch-project#2448)
5df8bd1 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibow98 yibow98 yibow98 left review comments

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@zhongnansu zhongnansu zhongnansu left review comments

@noCharger noCharger noCharger left review comments

@mpabba3003 mpabba3003 Awaiting requested review from mpabba3003

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
backport 2.x multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
8 participants
@kristenTian @zhongnansu @noCharger @seraphjiang @AMoo-Miki @zengyan-amazon @yibow98 @kavilla