Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Refactor and improve Discover field summaries #2391

Merged
merged 4 commits into from
Nov 3, 2022
Merged

[Chore] Refactor and improve Discover field summaries #2391

merged 4 commits into from
Nov 3, 2022

Commits on Nov 1, 2022

  1. [Chore] Refactor and improve field summaries 

    * Convert to typescript
* Fix types
* Add tests

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    a1b824b View commit details
    Browse the repository at this point in the history

  2. [Test] Update functional test 

    Groups are now naturally sorted by key, which requires selecting a different date filter

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    293ece9 View commit details
    Browse the repository at this point in the history

  3. [Chore] Add changelog entry 

    Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    6e8cea9 View commit details
    Browse the repository at this point in the history

  4. [Chore] Refactor columns passing, fix bugs 

    * pass columns explicitly as props
* fix branding in core mocks
* fix `toBeUndefined()` usage in tests
* remove leftover comment
* fix test subject
* condense types

Signed-off-by: Josh Romero <rmerqg@amazon.com>
    @joshuarrrr
    joshuarrrr committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    fe59826 View commit details
    Browse the repository at this point in the history