Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional test for search embeddable in Discover #5962

Closed
2 tasks
ananzh opened this issue Feb 27, 2024 · 1 comment
Closed
2 tasks

Add functional test for search embeddable in Discover #5962

ananzh opened this issue Feb 27, 2024 · 1 comment

Comments

@ananzh
Copy link
Member

ananzh commented Feb 27, 2024

In OSD, we don't have enough tests covering embeddable. For example, we find this bug which shows when dashboard loads a saved search, sort state is not loaded. Propose to add more tests:

  • Add unit test for search embeddable in Discover
  • Unit test should test the internal logic of the SearchEmbeddable class, ensuring that individual methods behave as expected under various conditions
  • Add functional test for search embeddable in Discover
  • Embeddable Rendering: Test that the embeddable renders correctly in the dashboard and displays the expected data. Test sort, columns, filter and etc are loaded correctly.
  • User Interactions: Verify that interactions (e.g., changing sort order, adding/removing columns) update the embeddable and the URL state.
  • Data Fetching and Display: Ensure that changing filters, queries, or time ranges updates the displayed data as expected.
@ananzh
Copy link
Member Author

ananzh commented Feb 27, 2024

duplicate

@ananzh ananzh closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant