Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Saved Search horizontal resizing not working #5653

Closed
joshuali925 opened this issue Jan 2, 2024 · 2 comments
Closed

[BUG] Saved Search horizontal resizing not working #5653

joshuali925 opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working discover for discover reinvent v2.15.0

Comments

@joshuali925
Copy link
Member

joshuali925 commented Jan 2, 2024

Describe the bug

In a dashboard that has a saved search at the bottom, add another visualization, it stacks with the saved search. Additionally saved search doesn't resize

To Reproduce
Steps to reproduce the behavior:

  1. Go to home page, add ecommerce sample data
  2. Click on view data
  3. Click on edit, add, add [eCommerce] Sales by Category
  4. See it stacked on top of the table
  5. Resize the saved search, it doesn't resize

Expected behavior
new visualization should be added at the bottom, and resize saved search should work like other visualizations

OpenSearch Version
2.11.0

Dashboards Version
2.11.0

Plugins

default distribution

Screenshots

image image

Host/Environment (please complete the following information):

  • OS: [e.g. iOS] linux x64
  • Browser and version [e.g. 22]

Additional context

I tried in 2.11.1, seems the visualization stack issue is fixed. Which PR fixed it? is it #5441? Also I still can't resize in 2.11.1

@joshuali925 joshuali925 added bug Something isn't working untriaged labels Jan 2, 2024
@ashwin-pc
Copy link
Member

ashwin-pc commented Jan 17, 2024

@joshuali925 Thanks for opening this issue. Yes it looks like #5441 did fix the overlap issue but not completely. What seems to be happening is that the underlying datagrid component is overflowing the parent embeddable (Resizeable component). You can see that the resize handle is still present and vertical resizing still works although horizontal resizing is still broken. Given that the stacking issue has been fixed, ill repurpose this issue to track the resizing issue instead. Let me know if see any reason not to do that :)

Recording of the horizontal resizing issue:

Screen.Recording.2024-01-16.at.4.53.09.PM.mov

@ashwin-pc ashwin-pc changed the title [BUG] Saved Search has styling issues in Dashboard [BUG] Saved Search horizontal resizing not working Jan 17, 2024
@ananzh ananzh self-assigned this Feb 7, 2024
@ananzh ananzh added discover for discover reinvent v2.13.0 labels Feb 7, 2024
@ashwin-pc ashwin-pc added v2.14.0 and removed v2.13.0 labels Mar 19, 2024
@ananzh ananzh added v2.15.0 and removed v2.14.0 labels May 4, 2024
@ananzh
Copy link
Member

ananzh commented Jun 7, 2024

Resolve this as it is done.

@ananzh ananzh closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discover for discover reinvent v2.15.0
Projects
None yet
Development

No branches or pull requests

4 participants