Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De-Angular] Clean angular context in Data plugin #5021

Open
2 tasks
ananzh opened this issue Sep 14, 2023 · 6 comments · May be fixed by #5682
Open
2 tasks

[De-Angular] Clean angular context in Data plugin #5021

ananzh opened this issue Sep 14, 2023 · 6 comments · May be fixed by #5682
Assignees
Labels
de-angular de-angularize work good first issue Good for newcomers v3.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Sep 14, 2023

  • Rename/Remove toAngularJSON(filter.input.query))
    This toAngularJSON function is a utility to convert an object into its JSON representation. The naming toAngularJSON might suggest that it was used by some Angular code, but from the provided implementation, it looks like a wrapper around the standard JSON.stringify method. Currently we completely removed AngularJS, therefore the simplest way to resolve is to just rename the method. The best way would be checking whether we could simply use JSON.stringify to replace this function.
  • Remove src/plugins/data/common/search/aggs/utils/to_angular_json.ts and clean src/plugins/data/common/search/aggs/utils/index.ts.
@ananzh ananzh added de-angular de-angularize work v2.11.0 labels Sep 14, 2023
@ananzh ananzh removed the untriaged label Sep 14, 2023
@ashwin-pc ashwin-pc added v3.0.0 and removed v2.11.0 labels Sep 22, 2023
@ashwin-pc
Copy link
Member

Marked the function as deprecated, it will be removed in 3.0

@abbyhu2000 abbyhu2000 added the good first issue Good for newcomers label Sep 26, 2023
@ShatilKhan
Copy link
Contributor

Hey can I work on this?
it would be great to have some more info

@wbeckler
Copy link

@ShatilKhan I believe the remaining work here is to remove references to angular while still getting tests to pass.

@ShatilKhan
Copy link
Contributor

I'm on it

@ShatilKhan
Copy link
Contributor

In the 1st part of the issue @ananzh stated
Update toAngularJSON(filter.input.query))
to toAngularJSON(filter.input.query)) in..
They are the same thing, so I was a bit confused, can you please tell me the correct replacement?

@ShatilKhan
Copy link
Contributor

PR is up
I've made one change only, a bit confused about the other changes requested
will try to discuss this in today's office hour

@ShatilKhan ShatilKhan linked a pull request Jan 11, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
de-angular de-angularize work good first issue Good for newcomers v3.0.0
Projects
None yet
5 participants