-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[De-Angular] Clean angular context in Data plugin #5021
Comments
Marked the function as deprecated, it will be removed in 3.0 |
Hey can I work on this? |
@ShatilKhan I believe the remaining work here is to remove references to angular while still getting tests to pass. |
I'm on it |
In the 1st part of the issue @ananzh stated |
PR is up |
toAngularJSON(filter.input.query))
This
toAngularJSON
function is a utility to convert an object into its JSON representation. The namingtoAngularJSON
might suggest that it was used by some Angular code, but from the provided implementation, it looks like a wrapper around the standardJSON.stringify
method. Currently we completely removed AngularJS, therefore the simplest way to resolve is to just rename the method. The best way would be checking whether we could simply useJSON.stringify
to replace this function.src/plugins/data/common/search/aggs/utils/to_angular_json.ts
and cleansrc/plugins/data/common/search/aggs/utils/index.ts
.The text was updated successfully, but these errors were encountered: