Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard De-Angular] Dashboard listing to use viewItem #4605

Open
Tracked by #3365
abbyhu2000 opened this issue Jul 20, 2023 · 2 comments
Open
Tracked by #3365

[Dashboard De-Angular] Dashboard listing to use viewItem #4605

abbyhu2000 opened this issue Jul 20, 2023 · 2 comments
Labels
dashboards de-angular de-angularize work enhancement New feature or request good first issue Good for newcomers

Comments

@abbyhu2000
Copy link
Member

abbyhu2000 commented Jul 20, 2023

Currently dashboard listing page uses href to view dashboards instead of utilizing onclick. Before the dashboard observability integration, the code utilized a getViewUrl prop to pass in a function; but this is dropped in favor of using viewUrl which is mapped from the viewUrlPathFn from the dashboard list provider.

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4502/files#r1258627999

@abbyhu2000 abbyhu2000 changed the title Dashboard listing to use viewItem [Dashboard De-Angular] Dashboard listing to use viewItem Jul 20, 2023
@abbyhu2000 abbyhu2000 added dashboards de-angular de-angularize work and removed untriaged labels Jul 20, 2023
@abbyhu2000 abbyhu2000 added the enhancement New feature or request label Sep 14, 2023
@abbyhu2000 abbyhu2000 added the good first issue Good for newcomers label Sep 26, 2023
@shawnkchan
Copy link

Hi, I would like to work on this issue. May I know where to start?

@joshuarrrr
Copy link
Member

@abbyhu2000 Can you explain a little more about why this is desirable? There are a11y benefits to using links with hrefs rather than a js action, because you get all the built-in browser functionality (such as open in a new tab). Elsewhere we've updated the visualization listing to have that behavior: #2395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboards de-angular de-angularize work enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants