Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove the whitesource check from non-main branches where it is unreliable #3711

Open
Tracked by #3710
joshuarrrr opened this issue Mar 27, 2023 · 1 comment
Labels
ci help wanted Community development is encouraged security feature

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Mar 27, 2023

On non-main branches, the whitesource check is marked as 'failed' even when no scan was triggered. For example, see https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3699/checks?check_run_id=12310441779

In main, such cases are not marked as failures: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3652/checks?check_run_id=12258568680

We need to fix this behavior, or limit the check to only main.

@joshuarrrr joshuarrrr changed the title Remove the whitesource check from non-main branches where it is unreliable Fix or remove the whitesource check from non-main branches where it is unreliable Mar 27, 2023
@joshuarrrr joshuarrrr added ci security feature help wanted Community development is encouraged and removed untriaged labels Mar 27, 2023
@AMoo-Miki
Copy link
Collaborator

I have a feeling that Mend is failing intentionally so we will not call them with every change unnecessarily; We should the Mend worflows to only when the lockfile or the package manifests change; we need the package manifests for cases where a version was bumped but a lock file was accidentally (or maliciously) omitted.

In short: we certainly want Mend scans run on all non-main branches; we just need to be frugal and so only when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci help wanted Community development is encouraged security feature
Projects
None yet
Development

No branches or pull requests

2 participants