Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Default legend size #3062

Open
kavilla opened this issue Dec 12, 2022 · 11 comments
Open

[FEATURE] Default legend size #3062

kavilla opened this issue Dec 12, 2022 · 11 comments
Labels
enhancement New feature or request unified visualization UX ux / ui Improvements or additions to user experience, flows, components, UI elements visualizations Issues and PRs related to visualizations

Comments

@kavilla
Copy link
Member

kavilla commented Dec 12, 2022

Is your feature request related to a problem? Please describe.

As an end-user I could have a dashboard with 2 TSVBs visualizations. Although the time range and interval is the same, the legends width seems to have a max width but has a default width based on the content inside.

If your series has a short value then your legend would be short and the ellipses calc would be smaller. If your series has a long value then your legend would probably be the max width and the ellipses calc would be longer.

For example, you can see the smaller legend:

Screen Shot 2022-12-11 at 6 54 05 PM

For example, you can see the longer legend:

Screen Shot 2022-12-11 at 6 54 18 PM

Describe the solution you'd like

An option to set my legend to a global default size so that it doesn't care about the content within the legend. It sets it to a logical size.

Describe alternatives you've considered

An option to custom configure the styling on the legend which would be inline with the amount of customization within TSVB.

I don't want to change my data or have it mutated prior to showing.

Additional context

Add any other context or screenshots about the feature request here.

@kavilla kavilla added enhancement New feature or request untriaged visualizations Issues and PRs related to visualizations ux / ui Improvements or additions to user experience, flows, components, UI elements labels Dec 12, 2022
@kavilla
Copy link
Member Author

kavilla commented Dec 12, 2022

@joshuarrrr @ashwin-pc this doesn't currently exist right?

@joshuarrrr
Copy link
Member

@kavilla Is the desired outcome here that time series are always scaled in a way that they can be vertically stacked and have the same x-axis? I'm not sure if that's practical on a dashboards page, because users can adjust the size of individual panels, as well as toggling the visibility of legend per panel.

@kavilla
Copy link
Member Author

kavilla commented Dec 13, 2022

@kavilla Is the desired outcome here that time series are always scaled in a way that they can be vertically stacked and have the same x-axis? I'm not sure if that's practical on a dashboards page, because users can adjust the size of individual panels, as well as toggling the visibility of legend per panel.

More that there is a global width that legends I can opt my visualization into so that instead of the app determining my width of my legend I can just set it to the default global width.

So hypothetically all my legends are the same width regardless of which visualization or the text length in the inside of the legend.

@joshuarrrr
Copy link
Member

gotcha. Yeah, standardized legend formatting is on the roadmap as part of the look & feel consolidation of visualizations. I don' have a meta issue for those yet, but when I do I'll use this as the stub for legend formatting in general.

@jcohen98
Copy link

Not only this, but when there are a lot of entries in the legend and the legend has a scroll bar, it cuts off all but the starting letter of each entry in the legend making it unusable

@joshuarrrr
Copy link
Member

Ugh, yeah, that's terrible @jcohen98. Is what you're describing also on the TSVB visualizations or on other visualization types? Right now there are lots of different legend implementations.

@jcohen98
Copy link

Right now it only seems like it affects TSVB. I did a quick test on the normal Line chart

@joshuarrrr
Copy link
Member

Thanks, that's helpful. Anecdotally, I'm somewhat surprised that the previous project maintainers released TSVB as a non-beta feature - it has lots of rough edges and bugs, even at the surface level.

@jcohen98
Copy link

Yeah I agree. Overall as a customer, I think it would be great if we can get more customization features around the look and feel of the entire dashboard interface past just this feature (Seems you have a plan for that as you referenced). But I'd like to adjust font sizes, have more color controls, and have excel-like "conditional formatting" in tables , etc

@joshuarrrr
Copy link
Member

@jcohen98 Yeah - if you don't mind, I'd love to see an issue that just lists your wish list for look and feel customizations and, particularly, the motivations for those adjustments. I do have a plan I'm working on for those things, but more customer feedback and input will make that plan more robust.

Alternatively, you can add comments to this stub proposal: #2830

Some of what you mention falls under what I have in mind for

Admin-level theming and chart preferences
User-level theming and chart preferences

At a high level, I'd like to improve the default visualization look, feel and behavior to reduce the need for customization, but also provide customization at the application level, user level, and individual visualization level, with the ability to override previous styles as you go more granular.

@BSFishy
Copy link
Contributor

BSFishy commented Jan 26, 2023

Tagging @KrooshalUX to provide some commentary from UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unified visualization UX ux / ui Improvements or additions to user experience, flows, components, UI elements visualizations Issues and PRs related to visualizations
Projects
None yet
Development

No branches or pull requests

4 participants