Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] opensearch-dashboards-data-source-audit.log do not have line separator on cygwin/msys/mingw #2764

Closed
peterzhuamazon opened this issue Nov 3, 2022 · 7 comments
Labels
bug Something isn't working multiple datasource multiple datasource project windows

Comments

@peterzhuamazon
Copy link
Member

Hi,

https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3383848918/jobs/5620140524#step:9:35

This will not happen on powershell but will happen on any mingw related emulated shell on windows.

bash: line 1: D:tmpopensearch-dashboards-data-source-audit.log: command not found

path: '/tmp/opensearch-dashboards-data-source-audit.log',

The path separator is removed in the process resulted in the log not able to be accessed.

Thanks.

@peterzhuamazon
Copy link
Member Author

After taking a look it is a non-issue, closing now.

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon peterzhuamazon reopened this Nov 8, 2022
@peterzhuamazon
Copy link
Member Author

Seems like fixed in this PR just not being pulled in the latest artifact.
#2793

@kavilla kavilla added the multiple datasource multiple datasource project label Nov 9, 2022
@kavilla
Copy link
Member

kavilla commented Nov 9, 2022

@kristenTian can we confirm?

@kristenTian
Copy link
Contributor

Yes, #2793 was merged in.

@kristenTian
Copy link
Contributor

@peterzhuamazon is there ways I can verify your end functions now as well?

@peterzhuamazon
Copy link
Member Author

I already confirmed this change is working in function test repo bundle e2e test.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project windows
Projects
None yet
Development

No branches or pull requests

3 participants