Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Allow create index patterns for indices with same name but from different datasources. #2597

Closed
Tracked by #2592
kristenTian opened this issue Oct 18, 2022 · 7 comments · Fixed by #3604
Closed
Tracked by #2592
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.7.0

Comments

@kristenTian
Copy link
Contributor

kristenTian commented Oct 18, 2022

I cannot create an index pattern with an existing name (I should be able to do so, since the data source should be part of the unique ID to disambiguate)

@kavilla kavilla added the multiple datasource multiple datasource project label Oct 18, 2022
@kristenTian kristenTian added the v2.5.0 'Issues and PRs related to version v2.5.0' label Oct 19, 2022
@kristenTian
Copy link
Contributor Author

kristenTian commented Oct 31, 2022

Pending tasks:

Done:

  • index pattern DS column support

@kristenTian kristenTian added the ux / ui Improvements or additions to user experience, flows, components, UI elements label Nov 7, 2022
@kristenTian
Copy link
Contributor Author

Need to append data source in front of index pattern, pending UX input on:

  • Save Object listing page support
  • Visualization creation
  • Discover page support

@zhongnansu
Copy link
Member

@kristenTian is this still on track for 2.5

@kristenTian
Copy link
Contributor Author

kristenTian commented Nov 23, 2022

Still pending confirming on the UX look for this task. we can work on it if there is bandwidth.

Base on Kevin and Kroosh, should just be simply pre-append the data source in front of data source everywhere.

@kristenTian kristenTian self-assigned this Nov 23, 2022
@joshuarrrr joshuarrrr added v2.6.0 and removed v2.5.0 'Issues and PRs related to version v2.5.0' labels Jan 9, 2023
@zhongnansu zhongnansu removed the v2.6.0 label Feb 13, 2023
@zhongnansu zhongnansu self-assigned this Feb 23, 2023
@zhongnansu zhongnansu changed the title Allow index pattern with same name create across different data sources [MD] Allow index pattern with same name create across different data sources Feb 23, 2023
@zhongnansu
Copy link
Member

zhongnansu commented Mar 1, 2023

Still pending confirming on the UX look for this task. we can work on it if there is bandwidth.

Base on Kevin and Kroosh, should just be simply pre-append the data source in front of data source everywhere.

I am working on this task to allow index-pattern created with same name but different datasources, and there will be some UX/UI changes needed across OSD components where they interact with index patterns. We propose prepending datasource name to index pattern name to distinguish them from UI. E.g. we could display 2 index pattern as datasource-1.index-pattern-name-1 and datasource-2.index-pattern-name-1. See screenshots in reference below for details.

As for the delimiter, I suggest we could use a forbidden character in index-pattern name, for example <>, \, /, instead of .

image

Based on the previous comment. I'd like to confirm with @kgcreative @KrooshalUX, that we are align on this before I start implementation.

References

  1. saved Object listing page:
    image
  2. visualization creation page:
    image
  3. Discover Page:
    image

cc: @zengyan-amazon @seraphjiang @kristenTian

@zhongnansu zhongnansu added the enhancement New feature or request label Mar 7, 2023
@zhongnansu zhongnansu changed the title [MD] Allow index pattern with same name create across different data sources [MD] Allow create index patterns for indices with same name but from different datasources. Mar 7, 2023
@joshuarrrr
Copy link
Member

@zhongnansu Will this be resolved by #3604?

@zhongnansu
Copy link
Member

@zhongnansu Will this be resolved by #3604?

@joshuarrrr yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.7.0
Projects
None yet
4 participants