Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] count and value_count Metric aggregation types misclassified and missing #2240

Open
ashwin-pc opened this issue Aug 31, 2022 · 1 comment
Labels

Comments

@ashwin-pc
Copy link
Member

Describe the bug

In OpenSearch Dashboards, we have count defined as a metric aggregation. There is however no metric aggregation of type count in OpenSearch Core and it seems to use the bucket.doc_count metadata field as its value.

Similarly value_count is in fact a valid metric aggregation type in OpenSearch Core but is missing in the list of metric aggregation types in OpenSearch Dashboards.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.2/src/plugins/data/common/search/aggs/metrics/metric_agg_types.ts to see the listed aggregation types

Expected behavior

There should not be a discrepancy between the different aggregation types and their classifications between OpenSearch Core and OpenSearch Dashboards and what they do.

OpenSearch Version
2.2

Dashboards Version
2.2

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@ashwin-pc ashwin-pc added bug Something isn't working untriaged labels Aug 31, 2022
@kavilla
Copy link
Member

kavilla commented Sep 27, 2022

[Triage]:

  1. There is a difference we need to research why the difference.
  • Note: There is a difference in total count and return result count that could be the difference but we don't explicitly know why there is a non-mapping of 1 to 1 based on what is in OpenSearch Dashboards vs OpenSearch.
  1. If there is a difference are we okay with that since we want to encourage the split? Or do we want to revisit that think about it should be disable if OpenSearch is not the data source.
  2. We should document any findings about the functionality about this metric agg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants