Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Save and Edit page input validation #1973

Closed
Tracked by #1733
noCharger opened this issue Jul 27, 2022 · 1 comment
Closed
Tracked by #1733

[MD] Save and Edit page input validation #1973

noCharger opened this issue Jul 27, 2022 · 1 comment
Assignees
Labels
multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements

Comments

@noCharger
Copy link
Contributor

noCharger commented Jul 27, 2022

Description:
In the save and edit credential page, we need to do input validation and show inline message to give user information for guiding.
image

@noCharger noCharger changed the title Input validation [MD] Save and Edit page input validation Jul 27, 2022
@joshuarrrr joshuarrrr added the multiple datasource multiple datasource project label Aug 1, 2022
@seraphjiang seraphjiang added the ux / ui Improvements or additions to user experience, flows, components, UI elements label Aug 14, 2022
@KrooshalUX
Copy link

KrooshalUX commented Aug 16, 2022

General guidance:
If any field is missing a value or otherwise contains an error, the submit button should remain in disabled state
Do not check for values onFocus

Credential Title Field (1)

  • onBlur & onChange - check for any value. If blank, display inline error
  • Preferably onBlur & onChange (vs onSubmit) - check if value exists as a credential title object. If the value is not unique, display inline error (this may not be part of P0)

Credential Description (2)

  • onBlur & onChange - check for any value. If blank, display inline error

Username (4)

  • onBlur & onChange - check for any value. If blank, display inline error

Password (5)

  • onBlur & onChange - check for any value. If blank, display inline error

onSubmit:

  • check for unique value in Title field. If the value is not unique, present user with an inline error as well as a Callout Error below the page description before the form
  • Return user scroll position to top
  • check for any disallowed characters in Credential Title and Credential Description (unsure if necessary, please verify)
  • listen for onChange on all fields in error to change submission button state from danger to default

Screen Shot 2022-08-16 at 9 59 07 AM

Screen Shot 2022-08-16 at 9 59 01 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
None yet
Development

No branches or pull requests

5 participants