Skip to content

Commit

Permalink
Fixes misleading embeddable plugin error message (#3043)
Browse files Browse the repository at this point in the history
Resolves #1479
Resolves #3083

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
  • Loading branch information
tmarkley and joshuarrrr authored Dec 28, 2022
1 parent 830c129 commit bd52024
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Vis Builder] Add global data persistence for vis builder #2896 ([#2896](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2896))
- Update `leaflet-vega` and fix its usage ([#3005](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3005))
- [Table Visualization][BUG] Fix Url content display issue in table ([#2918](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2918))
- Fixes misleading embaddable plugin error message ([#3043](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3043))
- [MD] Update dummy url in tests to follow lychee url allowlist ([#3099](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3099))

### 🚞 Infrastructure
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/lib/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class EmbeddableFactoryNotFoundError extends Error {
constructor(type: string) {
super(
i18n.translate('embeddableApi.errors.embeddableFactoryNotFound', {
defaultMessage: `{type} can't be loaded. Please upgrade to the default distribution of OpenSearch and OpenSearch Dashboards with the appropriate license.`,
defaultMessage: `OpenSearch Dashboards can't load "{type}" visualizations. Check for a missing plugin or an incompatible visualization type.`,
values: {
type,
},
Expand Down

0 comments on commit bd52024

Please sign in to comment.