Add more tests

Author: znicholls

src/pandas_openscm/db/netcdf.py

@@ -96,15 +96,21 @@ def save_data(self, data: pd.DataFrame, data_file: Path) -> None:
         # Resetting the index will also give each timeseries a unique ID
         data_rs = data.reset_index()
         timeseries_coord_info = {self.timeseries_dim: data_rs.index.values}
-        time_coord_info = {"time": data.columns}
+        if data.columns.name is None:
+            time_dim = "time"
+        else:
+            time_dim = data.columns.name
+
+        time_coord_info = {time_dim: data.columns.values}
+
         data_index_xr = metadata_df_to_xr(
             data_rs[data.index.names],
             timeseries_id_coord=xr.Coordinates(timeseries_coord_info),
             timeseries_dim=self.timeseries_dim,
         )
         data_values_xr = xr.DataArray(
             data,
-            dims=[self.timeseries_dim, "time"],
+            dims=[self.timeseries_dim, time_dim],
             coords=xr.Coordinates(timeseries_coord_info | time_coord_info),
         )
         data_xr = xr.merge([data_index_xr, data_values_xr.to_dataset(name="values")])

src/pandas_openscm/db/openscm_db.py

@@ -339,11 +339,11 @@ def from_gzipped_tar_archive(
                 ):
                     backend_data = DATA_BACKENDS.guess_backend(member.name)
 
-        if backend_data is None:  # pragma: noqa
+        if backend_data is None:  # pragma: no cover
             # Should be impossible to get here
             raise TypeError(backend_data)
 
-        if backend_index is None:  # pragma: noqa
+        if backend_index is None:  # pragma: no cover
             # Should be impossible to get here
             raise TypeError(backend_index)
 

tests/integration/database/test_integration_database_save_load.py

@@ -43,7 +43,7 @@ def test_save_and_load_basic(tmpdir, db_data_backend, db_index_backend):
 
     df_timeseries_like = pd.DataFrame(
         np.arange(12).reshape(4, 3),
-        columns=[2010, 2015, 2025],
+        columns=pd.Index([2010, 2015, 2025], name="year"),
         index=pd.MultiIndex.from_tuples(
             [
                 ("scenario_a", "climate_model_a", "Temperature", "K"),
@@ -70,7 +70,10 @@ def test_save_and_load_basic(tmpdir, db_data_backend, db_index_backend):
         df_timeseries_like.index, metadata_compare, exact="equiv", check_order=False
     )
 
-    loaded = db.load(out_columns_type=df_timeseries_like.columns.dtype)
+    loaded = db.load(
+        out_columns_type=df_timeseries_like.columns.dtype,
+        out_columns_name=df_timeseries_like.columns.name,
+    )
 
     assert_frame_alike(df_timeseries_like, loaded)
 

tests/unit/database/test_database.py

@@ -40,10 +40,31 @@ def test_available_backends_data():
 
 
 def test_unavailable_data_backend():
-    with pytest.raises(KeyError):
+    with pytest.raises(
+        KeyError, match=re.escape("option='junk' is not supported. Available options:")
+    ):
         DATA_BACKENDS.get_instance("junk")
 
 
+def test_guess_backend_data():
+    assert isinstance(DATA_BACKENDS.guess_backend("0.csv"), CSVDataBackend)
+    assert isinstance(DATA_BACKENDS.guess_backend("0.feather"), FeatherDataBackend)
+    assert isinstance(DATA_BACKENDS.guess_backend("0.in-mem"), InMemoryDataBackend)
+    assert isinstance(DATA_BACKENDS.guess_backend("0.nc"), netCDFDataBackend)
+
+
+def test_guess_data_backend_error():
+    with pytest.raises(
+        ValueError,
+        match=re.escape(
+            "Could not guess backend from data_file_name='0.junk'. "
+            "The file's extension does not match any of the available options: "
+            "known_options_and_extensions="
+        ),
+    ):
+        DATA_BACKENDS.guess_backend("0.junk")
+
+
 def test_available_backends_index():
     assert isinstance(INDEX_BACKENDS.get_instance("csv"), CSVIndexBackend)
     assert isinstance(INDEX_BACKENDS.get_instance("feather"), FeatherIndexBackend)
@@ -52,10 +73,31 @@ def test_available_backends_index():
 
 
 def test_unavailable_index_backend():
-    with pytest.raises(KeyError):
+    with pytest.raises(
+        KeyError, match=re.escape("option='junk' is not supported. Available options:")
+    ):
         INDEX_BACKENDS.get_instance("junk")
 
 
+def test_guess_backend_index():
+    assert isinstance(INDEX_BACKENDS.guess_backend("0.csv"), CSVIndexBackend)
+    assert isinstance(INDEX_BACKENDS.guess_backend("0.feather"), FeatherIndexBackend)
+    assert isinstance(INDEX_BACKENDS.guess_backend("0.in-mem"), InMemoryIndexBackend)
+    assert isinstance(INDEX_BACKENDS.guess_backend("0.nc"), netCDFIndexBackend)
+
+
+def test_guess_index_backend_error():
+    with pytest.raises(
+        ValueError,
+        match=re.escape(
+            "Could not guess backend from index_file_name='index.junk'. "
+            "The file's extension does not match any of the available options: "
+            "known_options_and_extensions="
+        ),
+    ):
+        INDEX_BACKENDS.guess_backend("index.junk")
+
+
 def test_filelock_not_available_default_initialisation(tmpdir):
     with patch.dict(sys.modules, {"filelock": None}):
         with pytest.raises(