Renamed load_file to serve_tmp_file

Author: akclace

internal/app/fs.go

@@ -37,7 +37,7 @@ func initFS() {
 		CreatePluginApi(h.Abs, READ),
 		CreatePluginApi(h.List, READ),
 		CreatePluginApi(h.Find, READ),
-		CreatePluginApiName(h.LoadFile, READ, "load_file"),
+		CreatePluginApiName(h.ServeTmpFile, READ, "serve_tmp_file"),
 		CreatePluginConstant(strings.ToUpper(string(UserAccess)), starlark.String(UserAccess)),
 		CreatePluginConstant(strings.ToUpper(string(AppAccess)), starlark.String(AppAccess)),
 	}

internal/app/fs_store.go

@@ -91,14 +91,14 @@ func backgroundCleanup(ctx context.Context, cleanupTicker *time.Ticker) {
 	fmt.Fprintf(os.Stderr, "background file cleanup stopped")
 }
 
-func (f *fsPlugin) LoadFile(thread *starlark.Thread, builtin *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
+func (f *fsPlugin) ServeTmpFile(thread *starlark.Thread, builtin *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
 	var pathVal, fileName starlark.String
 	visibility := starlark.String(UserAccess)
 	mimeType := starlark.String("application/octet-stream")
 	expiryMinutes := starlark.MakeInt(60)
 	singleAccess := starlark.Bool(true)
 
-	if err := starlark.UnpackArgs("load_file", args, kwargs, "path", &pathVal, "name?", &fileName, "visibility?", &visibility,
+	if err := starlark.UnpackArgs("serve_tmp_file", args, kwargs, "path", &pathVal, "name?", &fileName, "visibility?", &visibility,
 		"mime_type?", &mimeType, "expiry_minutes?", &expiryMinutes, "single_access", &singleAccess); err != nil {
 		return nil, err
 	}

tests/file_app/app.star

@@ -7,8 +7,8 @@ def handler(req):
    exec.run("sh", ["-c", "mkdir /tmp/fileapptmp"])
    ret1 = exec.run("sh", ["-c", "echo \"abc\" > /tmp/fileapptmp/testfileapp.txt"])
    ret11 = exec.run("sh", ["-c", "echo \"abc\" > /tmp/fileapptmp/testfileapp2.txt"])
-   ret2 = fs.load_file("/tmp/fileapptmp/testfileapp.txt") # single_access=True is default
-   ret3 = fs.load_file("/tmp/fileapptmp/testfileapp2.txt", single_access=False)
+   ret2 = fs.serve_tmp_file("/tmp/fileapptmp/testfileapp.txt") # single_access=True is default
+   ret3 = fs.serve_tmp_file("/tmp/fileapptmp/testfileapp2.txt", single_access=False)
 
    # First attempt works
    ret4 = http.get("http://localhost:25222" + ret2.value["url"])
@@ -38,7 +38,7 @@ def handler(req):
 app = ace.app("file test",
               routes = [ace.api("/", type=ace.TEXT)],
               permissions = [
-              ace.permission("fs.in", "load_file"),
+              ace.permission("fs.in", "serve_tmp_file"),
               ace.permission("fs.in", "find"),
               ace.permission("exec.in", "run"),
               ace.permission("http.in", "get")]