Added app url in create output

Author: akclace

cmd/clace/app_cmds.go

@@ -146,6 +146,13 @@ Examples:
 				fmt.Print("App created. No approval required\n")
 			}
 
+			if createResult.HttpUrl != "" {
+				fmt.Printf("\n HTTP Url: %s\n", createResult.HttpUrl)
+			}
+			if createResult.HttpsUrl != "" {
+				fmt.Printf("HTTPS Url: %s\n", createResult.HttpsUrl)
+			}
+
 			if createResult.DryRun {
 				fmt.Print(DRY_RUN_MESSAGE)
 			}

cmd/clace/preview_cmds.go

@@ -80,6 +80,13 @@ func previewCreateCommand(commonFlags []cli.Flag, clientConfig *types.ClientConf
 				fmt.Printf("App creation %s. No approval required\n", status)
 			}
 
+			if previewResponse.HttpUrl != "" {
+				fmt.Printf("\n HTTP Url: %s\n", previewResponse.HttpUrl)
+			}
+			if previewResponse.HttpsUrl != "" {
+				fmt.Printf("HTTPS Url: %s\n", previewResponse.HttpsUrl)
+			}
+
 			if previewResponse.DryRun {
 				fmt.Print(DRY_RUN_MESSAGE)
 			}

internal/server/app_apis.go

@@ -4,6 +4,7 @@
 package server
 
 import (
+	"cmp"
 	"context"
 	"errors"
 	"fmt"
@@ -222,6 +223,8 @@ func (s *Server) createApp(ctx context.Context, appEntry *types.AppEntry, approv
 	}
 
 	ret := &types.AppCreateResponse{
+		HttpUrl:        s.getAppHttpUrl(appEntry),
+		HttpsUrl:       s.getAppHttpsUrl(appEntry),
 		DryRun:         dryRun,
 		ApproveResults: results,
 	}
@@ -238,6 +241,24 @@ func (s *Server) createApp(ctx context.Context, appEntry *types.AppEntry, approv
 	return ret, nil
 }
 
+// getAppHttpUrl returns the HTTP URL for accessing the app
+func (s *Server) getAppHttpUrl(appEntry *types.AppEntry) string {
+	if s.config.Http.Port <= 0 {
+		return ""
+	}
+	domain := cmp.Or(appEntry.Domain, "localhost")
+	return fmt.Sprintf("%s://%s:%d%s", "http", domain, s.config.Http.Port, appEntry.Path)
+}
+
+// getAppHttpsUrl returns the HTTPS URL for accessing the app
+func (s *Server) getAppHttpsUrl(appEntry *types.AppEntry) string {
+	if s.config.Https.Port <= 0 {
+		return ""
+	}
+	domain := cmp.Or(appEntry.Domain, "localhost")
+	return fmt.Sprintf("%s://%s:%d%s", "https", domain, s.config.Https.Port, appEntry.Path)
+}
+
 func (s *Server) setupApp(appEntry *types.AppEntry, tx types.Transaction) (*app.App, error) {
 	subLogger := s.With().Str("id", string(appEntry.Id)).Str("path", appEntry.Path).Logger()
 	appLogger := types.Logger{Logger: &subLogger}
@@ -907,6 +928,8 @@ func (s *Server) PreviewApp(ctx context.Context, mainAppPath, commitId string, a
 
 	ret := &types.AppPreviewResponse{
 		DryRun:        dryRun,
+		HttpUrl:       s.getAppHttpUrl(&previewAppEntry),
+		HttpsUrl:      s.getAppHttpsUrl(&previewAppEntry),
 		ApproveResult: *auditResult,
 		Success:       true,
 	}

internal/types/api.go

@@ -92,6 +92,8 @@ type AppListResponse struct {
 
 type AppCreateResponse struct {
 	DryRun         bool            `json:"dry_run"`
+	HttpUrl        string          `json:"http_url"`
+	HttpsUrl       string          `json:"https_url"`
 	ApproveResults []ApproveResult `json:"approve_results"`
 }
 
@@ -131,6 +133,8 @@ type AppUpdateSettingsResponse struct {
 
 type AppPreviewResponse struct {
 	DryRun        bool          `json:"dry_run"`
+	HttpUrl       string        `json:"http_url"`
+	HttpsUrl      string        `json:"https_url"`
 	Success       bool          `json:"success"`
 	ApproveResult ApproveResult `json:"approve_result"`
 }

tests/commander/test_load_app.yaml

@@ -135,15 +135,15 @@ tests:
     exit-code: 1
   load0270: # Create app, valid branch
     command: ../clace app create --approve --branch main https://github.com/claceio/clace/examples/disk_usage /ghload3
-    stdout: "App created. Permissions have been approved"
+    stdout: "HTTPS Url: https://localhost:25223/ghload3"
     exit-code: 0
   load0280: # Create app, invalid commit id.
     command: ../clace app create --approve --commit invalid https://github.com/claceio/clace/examples/disk_usage /ghload4
     stderr: "reference not found"
     exit-code: 1
   load0290: # Create app, valid commit id
     command: ../clace app create --approve --commit 6574d08b47abb71636665fbcbad51c2f7e8cab71 https://github.com/claceio/clace/examples/disk_usage /ghload5
-    stdout: "App created. Permissions have been approved"
+    stdout: "HTTP Url: http://localhost:25222/ghload5"
     exit-code: 0
 
   load0900: # cleanup