Skip to content

Commit

Permalink
lists: remove a redundant conditional definition of list_add()
Browse files Browse the repository at this point in the history
Remove the conditional surrounding the definition of list_add() from list.h
since, if you define CONFIG_DEBUG_LIST, the definition you will subsequently
pick up from lib/list_debug.c will be absolutely identical, at which point you
can remove that redundant definition from list_debug.c as well.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
rpjday authored and torvalds committed Jul 25, 2008
1 parent fd19382 commit e0ce0da
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
4 changes: 0 additions & 4 deletions include/linux/list.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,10 @@ extern void __list_add(struct list_head *new,
* Insert a new entry after the specified head.
* This is good for implementing stacks.
*/
#ifndef CONFIG_DEBUG_LIST
static inline void list_add(struct list_head *new, struct list_head *head)
{
__list_add(new, head, head->next);
}
#else
extern void list_add(struct list_head *new, struct list_head *head);
#endif


/**
Expand Down
14 changes: 0 additions & 14 deletions lib/list_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,6 @@ void __list_add(struct list_head *new,
}
EXPORT_SYMBOL(__list_add);

/**
* list_add - add a new entry
* @new: new entry to be added
* @head: list head to add it after
*
* Insert a new entry after the specified head.
* This is good for implementing stacks.
*/
void list_add(struct list_head *new, struct list_head *head)
{
__list_add(new, head, head->next);
}
EXPORT_SYMBOL(list_add);

/**
* list_del - deletes entry from list.
* @entry: the element to delete from the list.
Expand Down

0 comments on commit e0ce0da

Please sign in to comment.