JUnit Jupiter's vintage engine was removed in Spring Boot 2.4

[josemariavillar]

Good morning,

The recipe that upgrades to Spring Boot 2.4 includes by default the migration from JUnit4 to 5. This recipe is responsible for excluding the junit-vintage-engine dependency since the JUnit Jupiter's vintage engine was removed in Spring Boot 2.4. But if for some reason the application has this dependency defined in its POM it is not removed, having to remove it manually for it to work. wouldn't it be logical to include that this dependency is removed if it is defined?

https://github.com/openrewrite/rewrite-spring/blob/ee19bc944fc141da4de3effc07313076a638e0ab/src/main/resources/META-INF/rewrite/spring-boot2-upgrade-version.yml#L155

[pway99]

thanks @josemariavillar, lots of effort on rewrite maven resolution and recipes going on right now. Once those changes are complete we can revisit this issue and make any necessary changes.