Polish. Updated MigrateHttpURLConnectionHttpServerErrorToHttpInternalError with type cache changes. Removed unused imports in MigrateLoggerGlobalToGetGlobal. Updated tests.

Author: traceyyoshima

src/main/java/org/openrewrite/java/migrate/logging/MigrateLoggerGlobalToGetGlobal.java

@@ -17,19 +17,12 @@
 
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Recipe;
-import org.openrewrite.Tree;
 import org.openrewrite.TreeVisitor;
-import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.search.UsesType;
 import org.openrewrite.java.tree.J;
-import org.openrewrite.java.tree.JContainer;
-import org.openrewrite.java.tree.JRightPadded;
 import org.openrewrite.java.tree.TypeUtils;
-import org.openrewrite.marker.Markers;
-
-import java.util.Collections;
 
 public class MigrateLoggerGlobalToGetGlobal extends Recipe {
     @Override

src/main/java/org/openrewrite/java/migrate/net/MigrateHttpURLConnectionHttpServerErrorToHttpInternalError.java

@@ -49,15 +49,15 @@ protected TreeVisitor<?, ExecutionContext> getVisitor() {
     private static class MigrateHttpURLConnectionHttpServerErrorToHttpInternalErrorVisitor extends JavaIsoVisitor<ExecutionContext> {
         @Override
         public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
-            doAfterVisit(new ChangeFieldName<>(JavaType.Class.build("java.net.HttpURLConnection"), "HTTP_SERVER_ERROR", "HTTP_INTERNAL_ERROR"));
+            doAfterVisit(new ChangeFieldName<>("java.net.HttpURLConnection", "HTTP_SERVER_ERROR", "HTTP_INTERNAL_ERROR"));
             return super.visitCompilationUnit(cu, ctx);
         }
 
         @Override
         public J.Identifier visitIdentifier(J.Identifier identifier, ExecutionContext ctx) {
             if ("HTTP_SERVER_ERROR".equals(identifier.getSimpleName())) {
-                if (identifier.getFieldType() instanceof JavaType.Variable) {
-                    JavaType.FullyQualified fq = TypeUtils.asFullyQualified(((JavaType.Variable) identifier.getFieldType()).getOwner());
+                if (identifier.getFieldType() != null) {
+                    JavaType.FullyQualified fq = TypeUtils.asFullyQualified(identifier.getFieldType().getOwner());
                     if (fq != null && "java.net.HttpURLConnection".equals(fq.getFullyQualifiedName())) {
                         identifier = identifier.withName("HTTP_INTERNAL_ERROR");
                     }

src/test/kotlin/org/openrewrite/java/migrate/guava/NoGuavaImmutableListOfTest.kt

@@ -261,7 +261,7 @@ class NoGuavaImmutableListOfTest : JavaRecipeTest {
             import java.util.List;
 
             public class A {
-                List<String, String> list;
+                List<String> list;
                 public A(List<String> list) {
                     this.list = list;
                 }

src/test/kotlin/org/openrewrite/java/migrate/guava/NoGuavaImmutableSetOfTest.kt

@@ -261,7 +261,7 @@ class NoGuavaImmutableSetOfTest : JavaRecipeTest {
             import java.util.Set;
 
             public class A {
-                Set<String, String> set;
+                Set<String> set;
                 public A(Set<String> set) {
                     this.set = set;
                 }