Skip to content

Commit dda4fa4

Browse files
authored
Drop intermediate JavaVersion11/17/21 recipes (#468)
* Drop intermediate JavaVersion11/17/21 recipes These only delegate to UpgradeJavaVersion, but had a displayName and description that were Maven specific, despite also updating Gradle build files, and source file markers after 9c6acfb * Drop duplicate tests
1 parent e31312e commit dda4fa4

File tree

5 files changed

+34
-179
lines changed

5 files changed

+34
-179
lines changed

src/main/resources/META-INF/rewrite/java-version-11.yml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,12 @@ recipeList:
5757
- org.openrewrite.java.migrate.cobertura.RemoveCoberturaMavenPlugin
5858
- org.openrewrite.java.migrate.wro4j.UpgradeWro4jMavenPluginVersion
5959
- org.openrewrite.java.migrate.jacoco.UpgradeJaCoCoMavenPluginVersion
60-
- org.openrewrite.java.migrate.JavaVersion11
60+
- org.openrewrite.java.migrate.UpgradeJavaVersion:
61+
version: 11
62+
- org.openrewrite.maven.UpgradePluginVersion:
63+
groupId: org.apache.maven.plugins
64+
artifactId: maven-compiler-plugin
65+
newVersion: 3.6.2
6166
# Disabled due to null safety issues in the current implementation
6267
# https://github.com/openrewrite/rewrite-migrate-java/issues/250
6368
# - org.openrewrite.java.migrate.util.JavaUtilAPIs
@@ -71,18 +76,6 @@ recipeList:
7176

7277
---
7378
type: specs.openrewrite.org/v1beta/recipe
74-
name: org.openrewrite.java.migrate.JavaVersion11
75-
displayName: Change Maven Java version property values to 11
76-
description: Change maven.compiler.source and maven.compiler.target values to 11.
77-
recipeList:
78-
- org.openrewrite.java.migrate.UpgradeJavaVersion:
79-
version: 11
80-
- org.openrewrite.maven.UpgradePluginVersion:
81-
groupId: org.apache.maven.plugins
82-
artifactId: maven-compiler-plugin
83-
newVersion: 3.6.2
84-
---
85-
type: specs.openrewrite.org/v1beta/recipe
8679
name: org.openrewrite.java.migrate.javax.AddJaxbDependencies
8780
displayName: Add explicit JAXB dependencies
8881
description: >

src/main/resources/META-INF/rewrite/java-version-17.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ tags:
2727
- java17
2828
recipeList:
2929
- org.openrewrite.java.migrate.Java8toJava11
30-
- org.openrewrite.java.migrate.JavaVersion17
30+
- org.openrewrite.java.migrate.UpgradeJavaVersion:
31+
version: 17
3132
- org.openrewrite.java.migrate.lang.StringFormatted
3233
- org.openrewrite.github.SetupJavaUpgradeJavaVersion:
3334
minimumJavaMajorVersion: 17
@@ -57,17 +58,6 @@ recipeList:
5758
- org.openrewrite.java.migrate.RemovedFileIOFinalizeMethods
5859
---
5960
type: specs.openrewrite.org/v1beta/recipe
60-
name: org.openrewrite.java.migrate.JavaVersion17
61-
displayName: Change Maven Java version property values to 17
62-
description: Change maven.compiler.source and maven.compiler.target values to 17.
63-
tags:
64-
- java17
65-
- compiler
66-
recipeList:
67-
- org.openrewrite.java.migrate.UpgradeJavaVersion:
68-
version: 17
69-
---
70-
type: specs.openrewrite.org/v1beta/recipe
7161
name: org.openrewrite.java.migrate.DeprecatedJavaxSecurityCert
7262
displayName: Use `java.security.cert` instead of `javax.security.cert`
7363
description: The `javax.security.cert` package has been deprecated for removal.

src/main/resources/META-INF/rewrite/java-version-21.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ tags:
2525
- java21
2626
recipeList:
2727
- org.openrewrite.java.migrate.UpgradeToJava17
28-
- org.openrewrite.java.migrate.JavaVersion21
28+
- org.openrewrite.java.migrate.UpgradeJavaVersion:
29+
version: 21
2930
- org.openrewrite.java.migrate.RemoveIllegalSemicolons
3031
- org.openrewrite.java.migrate.lang.ThreadStopUnsupported
3132
- org.openrewrite.java.migrate.net.URLConstructorsToURIRecipes
@@ -61,17 +62,6 @@ recipeList:
6162

6263
---
6364
type: specs.openrewrite.org/v1beta/recipe
64-
name: org.openrewrite.java.migrate.JavaVersion21
65-
displayName: Change Maven Java version property values to 21
66-
description: Change maven.compiler.source and maven.compiler.target values to 21.
67-
tags:
68-
- java21
69-
- compiler
70-
recipeList:
71-
- org.openrewrite.java.migrate.UpgradeJavaVersion:
72-
version: 21
73-
---
74-
type: specs.openrewrite.org/v1beta/recipe
7565
name: org.openrewrite.java.migrate.util.SequencedCollection
7666
displayName: Adopt `SequencedCollection`
7767
description: Replace older code patterns with `SequencedCollection` methods, as per https://openjdk.org/jeps/431.

src/test/java/org/openrewrite/java/migrate/UpdateMavenToJava11Test.java

Lines changed: 0 additions & 142 deletions
This file was deleted.

src/test/java/org/openrewrite/java/migrate/UpgradeJavaVersionTest.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,30 @@ void gradleSourceTargetFromJava11ToJava17() {
183183
);
184184
}
185185

186+
@Test
187+
void gradleSourceTargetFromJava11ToJava21ThroughEnum() {
188+
rewriteRun(
189+
spec -> spec.recipe(new UpgradeJavaVersion(21)),
190+
buildGradle(
191+
//language=groovy
192+
"""
193+
java {
194+
sourceCompatibility = JavaVersion.VERSION_11
195+
targetCompatibility = JavaVersion.VERSION_11
196+
}
197+
""",
198+
//language=groovy
199+
"""
200+
java {
201+
sourceCompatibility = JavaVersion.VERSION_21
202+
targetCompatibility = JavaVersion.VERSION_21
203+
}
204+
""",
205+
spec -> spec.markers(new JavaVersion(UUID.randomUUID(), "", "", "11.0.15+10", "11.0.15+10"))
206+
)
207+
);
208+
}
209+
186210
@Test
187211
void gradleNoChangeIfUpgradeFromJava11ToJava8() {
188212
rewriteRun(

0 commit comments

Comments
 (0)