Commit b8a298e
authored
Fix
`when` guards are only valid on pattern case labels, but the recipe
also matched constant labels (e.g. enum constants) when the `if`
condition referenced no label-bound variables, producing uncompilable
code with a duplicate case. Require the case label to bind pattern
variables before refining.
Fixes #1123RefineSwitchCases generating invalid guard on enum constant labels (#1124)1 parent c7f400b commit b8a298e
2 files changed
Lines changed: 41 additions & 2 deletions
File tree
- src
- main/java/org/openrewrite/java/migrate/lang
- test/java/org/openrewrite/java/migrate/lang
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
| |||
Lines changed: 36 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
296 | 332 | | |
297 | 333 | | |
298 | 334 | | |
| |||
0 commit comments