Fix compilation on K.CompilationUnit.service #593
Conversation
| @@ -341,7 +341,7 @@ public K.CompilationUnit withStatements(List<JRightPadded<Statement>> statements | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("unchecked") | |||
| public <S> S service(Class<S> service) { | |||
| public <S, T extends S> T service(Class<S> service) { | |||
| String serviceName = service.getName(); | |||
| try { | |||
| Class<S> serviceClass; | |||
There was a problem hiding this comment.
Had my doubts here whether Class<S> should be Class<T> too here or in the casts below. 🤔
There was a problem hiding this comment.
I think it should. As T extends S and you are returning T you can cast T to S but not S to T.
edit: nope, this seems to be intentional. We check for a supertype S and find the subtype T for it.
There was a problem hiding this comment.
@sambsnyd any insight here appreciated; wouldn't want to hide a compile error with a misplaced cast.
There was a problem hiding this comment.
I might not have needed to change this signature originally. Whether it returns S or T extends S the meaning, and opportunities for ClassCastException are largely the same.
|
Pushed a similar change to rewrite-javascript such that does not fall out of line with our releases openrewrite/rewrite-javascript@8a6d7e8 |
After openrewrite/rewrite@33d8f7d