Skip to content

chore: delete unnecessary resp arg according to get_tls1_version_str's signature #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: delete unnecessary resp arg according to get_tls1_version_str's signature #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions t/ssl.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ lua ssl server name: "test.com"
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -1129,7 +1129,7 @@ got TLS1 version: SSLv3,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -1206,7 +1206,7 @@ got TLS1 version: TLSv1,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -1283,7 +1283,7 @@ got TLS1 version: TLSv1.1,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -2290,7 +2290,7 @@ qr/subject=\/?C(?<eq>\s?=\s?)US(?<sep>\/|,\s)ST\k<eq>California\k<sep>L\k<eq>San
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down
10 changes: 5 additions & 5 deletions t/stream/ssl.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ lua ssl server name: "test.com"
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -882,7 +882,7 @@ got TLS1 version: SSLv3,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -948,7 +948,7 @@ got TLS1 version: TLSv1,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -1014,7 +1014,7 @@ got TLS1 version: TLSv1.1,
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down Expand Up @@ -1849,7 +1849,7 @@ qr/subject=\/?C(?<eq>\s?=\s?)US(?<sep>\/|,\s)ST\k<eq>California\k<sep>L\k<eq>San
ssl_certificate_by_lua_block {
local ssl = require "ngx.ssl"

local ver, err = ssl.get_tls1_version_str(resp)
local ver, err = ssl.get_tls1_version_str()
if not ver then
ngx.log(ngx.ERR, "failed to get TLS1 version: ", err)
return
Expand Down
Loading