-
Notifications
You must be signed in to change notification settings - Fork 1
Added GitHub Actions Release flow #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…/service-ml-forecast into cicd/release-workflow
denniskuijs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, just a few minor changes.
.github/workflows/release.yml
Outdated
| workflow_dispatch: | ||
| inputs: | ||
| VERSION_INCREMENT: | ||
| description: "The version number part to increment (major.minor.patch)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small cosmetic change: replace double quotes with single quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to single quotes.
Seems they were accidentally changed to double quotes due to the formatter I use.
.github/workflows/docker-image.yml
Outdated
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 # v3.6.0 | ||
| with: | ||
| platforms: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe only include the platforms that are necessary: linux/amd64,linux/arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I've changed it so it specifies the platforms now.
Closes #10
This PR introduces the following GitHub Actions workflows:
docker-image.ymlmainor when a release is publishedci.ymlto run code quality checkslatestdeveloprelease.ymlbased on the
release.ymlfrom the main repositorybump-my-versionto handle version management:pyproject.tomlchore: bump version to {version}. Python projects/packages expect the version to be explicitly maintained inpyproject.toml, so this automates thatmainbranchdocker-image.ymlflowI've also reset the version back to the original
0.1.0, which will be incremented once releases are made.Additionally, this PR includes minor changes to
ci.yml, primarily aimed at improving readability/formatting, and adds arelease.ymlfile to the root of the.githubfolder, which is used to generate the release notes.I've also set up the secrets for the GitHub repository and created the repository on DockerHub.