Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No automatic reconnection #2

Open
poggs opened this issue Mar 20, 2019 · 2 comments
Open

No automatic reconnection #2

poggs opened this issue Mar 20, 2019 · 2 comments

Comments

@poggs
Copy link
Member

poggs commented Mar 20, 2019

If the connection fails, the client does not automatically reconnect itself - it just waits for a period of time and exits.

Ideally it should reconnect itself and log the disconnection.

@pauldj54
Copy link

pauldj54 commented Mar 3, 2020

Hi @poggs ,
I would like to ask if you solve the reconnection issue. My client is getting disconnect quite often and I am not able to determine where reside the problem:
image
Thanks,
Paul

@EvelynSubarrow
Copy link

The main issue with implementing this is that the way stomp.py handles disconnects and reconnects is completely and utterly broken, in some cases the disconnect handler will be fired twice, in some cases (but not others), it'll be run during a failure to connect (especially irritating and problematic if your disconnect handler tries more than once to connect), and in some cases (but not others) an apparently successful reconnection will yield a listener which believes it's connected, but never receives anything ever again

I've made some headway on semaphore-involving workarounds for these issues in ironswallow, which need some more testing, but I'd be happy to submit a PR when I've got something which works reliably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants