Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thresholded metrics #45

Merged
merged 2 commits into from
May 22, 2024
Merged

add thresholded metrics #45

merged 2 commits into from
May 22, 2024

Conversation

szalata
Copy link
Collaborator

@szalata szalata commented May 22, 2024

Describe your changes

add thresholded metrics

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@szalata szalata requested a review from rcannood May 22, 2024 19:57
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to include these metrics in the next run

Comment on lines +25 to +32
description: |
We use the **Mean Rowwise Root Mean Squared Error** to score submissions, computed as follows:

$$
\textrm{MRRMSE} = \frac{1}{R}\sum\_{i=1}^R\left(\frac{1}{n} \sum\_{j=1}^{n} (y\_{ij} - \widehat{y}\_{ij})^2\right)^{1/2}
$$

where $\\(R\\)$ is the number of scored rows, and $\\(y_{ij}\\)$ and $\\(\widehat{y}_{ij}\\)$ are the actual and predicted values, respectively, for row $\\(i\\)$ and column $\\(j\\)$, and $\\(n\\)$ bis the number of columns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps trim the description to the bare minimum to avoid confusion?

@rcannood rcannood merged commit c501ebc into main May 22, 2024
7 checks passed
@rcannood rcannood deleted the metric_thresholding branch May 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants