Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move marketvolume_test to colocate with its package #248

Closed
ajlacey opened this issue Aug 16, 2024 · 1 comment
Closed

move marketvolume_test to colocate with its package #248

ajlacey opened this issue Aug 16, 2024 · 1 comment
Labels
go Pull requests that update Go code good first issue Good for newcomers

Comments

@ajlacey
Copy link
Collaborator

ajlacey commented Aug 16, 2024

move test from backend/tests/market_math/marketvolume_test.go to the package it is testing to handlers/math/market package here: backend/handlers/math/market/marketvolume_test.go

This test uses a table-driven test format.
A common convention for these is to name the table tests or testCases, when using this convention it is best to use test or tc respectively in the loop here: https://github.com/openpredictionmarkets/socialpredict/blob/main/backend/tests/market_math/marketvolume_test.go#L69-L76
Update this loop to follow this convention during the move.
Add a test description (comment) here: https://github.com/openpredictionmarkets/socialpredict/blob/main/backend/tests/market_math/marketvolume_test.go#L9

@ajlacey ajlacey added go Pull requests that update Go code good first issue Good for newcomers labels Aug 16, 2024
@snagai
Copy link
Contributor

snagai commented Aug 16, 2024

Hello @ajlacey
May I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants