Skip to content

Commit 4577b6b

Browse files
committed
test: use a unique deploy alias per test group
See inline comment.
1 parent be87fe3 commit 4577b6b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/test-e2e.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,10 @@ jobs:
198198
NODE_ENV: production
199199
NEXT_EXTERNAL_TESTS_FILTERS: ${{ steps.test-filters.outputs.filters }}
200200
NEXT_TEST_SKIP_RETRY_MANIFEST: ${{ steps.test-filters.outputs.skip-retry }}
201+
# Use a unique alias per test matrix group and shard. Otherwise, a deploy within
202+
# one job may wait for deploys in other jobs (only one deploy may be in progress for
203+
# a given alias at a time), resulting in cascading timeouts.
204+
DEPLOY_ALIAS: vercel-next-e2e-${{ matrix.version_spec.selector }}-${{ matrix.group }}
201205
run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e
202206
working-directory: ${{ env.next-path }}
203207

tests/netlify-deploy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class NextDeployInstance extends NextInstance {
133133
const deployTitle = process.env.GITHUB_SHA
134134
? `${testName} - ${process.env.GITHUB_SHA}`
135135
: testName
136-
const deployAlias = 'vercel-next-e2e'
136+
const deployAlias = process.env.DEPLOY_ALIAS ?? 'vercel-next-e2e'
137137

138138
const deployResPromise = execa(
139139
'npx',

0 commit comments

Comments
 (0)