Skip to content

Commit 8ddb621

Browse files
authored
fix lambda streaming hanging after return (#487)
* fix lambda hanging after return * Create lucky-ravens-teach.md
1 parent c8d692b commit 8ddb621

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.changeset/lucky-ravens-teach.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"open-next": patch
3+
---
4+
5+
fix lambda streaming hanging after return

packages/open-next/src/types/aws-lambda.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export interface ResponseStream extends Writable {
99
type Handler = (
1010
event: APIGatewayProxyEventV2,
1111
responseStream: ResponseStream,
12-
context?: Context,
12+
context: Context,
1313
) => Promise<any>;
1414

1515
interface Metadata {

packages/open-next/src/wrappers/aws-lambda-streaming.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ function formatWarmerResponse(event: WarmerEvent) {
2323

2424
const handler: WrapperHandler = async (handler, converter) =>
2525
awslambda.streamifyResponse(
26-
async (event: AwsLambdaEvent, responseStream): Promise<AwsLambdaReturn> => {
26+
async (
27+
event: AwsLambdaEvent,
28+
responseStream,
29+
context,
30+
): Promise<AwsLambdaReturn> => {
31+
context.callbackWaitsForEmptyEventLoop = false;
2732
if ("type" in event) {
2833
const result = await formatWarmerResponse(event);
2934
responseStream.end(Buffer.from(JSON.stringify(result)), "utf-8");

0 commit comments

Comments
 (0)