Merge remote-tracking branch 'remotes/upstream/shorter-user-errors' into Branch_burger

# Conflicts:
#	source/amx/amx.h

Author: Y_Less

.github/CONTRIBUTING.md

@@ -1,8 +1,6 @@
 # Contributing to the Pawn Compiler
 
-When contributing to this repository, please first discuss the change you wish to make via issue, email, or any other method with the owners of this repository before making a change.
-
-Please note we have a code of conduct, please follow it in all your interactions with the project.
+If you are proposing a new feature or fixing a bug of significant complexity, please do not write any code and propose your planned changes via an issue first! This saves _you_ time in case changes are required or the feature is rejected and it saves the _maintainers_ time as discussing proposals is generally easier than doing code review. Thank you!
 
 ## Pull Requests
 

.github/ISSUE_TEMPLATE.md

@@ -25,7 +25,7 @@ Learn more about writing MCVE from [StackOverflow](https://stackoverflow.com/hel
 If this section is not relevant, feel free to remove this section from your issue.
 -->
 
-```
+```Pawn
 ```
 
 <!-- comments on the code, if any -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -12,7 +12,11 @@ Never pull to `master` - always pull to `dev` or a relevant feature branch.
 
 **Which issue(s) this PR fixes**:
 
-<!--GitHub tip: using "Fixes #<issue number> will automatically close the issue upon being merged-->
+<!--
+Please ensure you have discussed your proposed changes before committing time to writing code!
+
+GitHub tip: using "Fixes #<issue number> will automatically close the issue upon being merged
+-->
 
 Fixes #
 

.travis.yml

@@ -31,7 +31,7 @@ after_failure:
 deploy:
   provider: releases
   api_key:
-    secure: gDAuRNlF2uVhVHyZtJrX6MwNxnkfkQzohrC/6UcKAgqt+NKs4vZyq5FzTUceiDAkB0se70ZVx08e9ibAiXP/b7D1MPkAEiRxt9J6Vu3x6Bi1kPPuK5RfjFeT3gc1SbrULAP8Nz0NdU0chUhei6/V5NGhTegwp925DJOISq7+Ibw=
+    secure: T90PePvue0C/4u5EwZKGLUc/aXyu2U2XMGDzdNdpla6wXONWABg3F6mY3vYXRRxdWPhz8W6qEFwQmbEIIExxLFrgH8CUGDoF/9dftaCxJIBw59WRwfbaIAWiK5p6wLzZBfRuZQWJMwWdjDu8woAYzfxWBL37hbZateUrcAB7lkc=
   file_glob: true
   file:
     - 'pawnc-*-linux.tar.gz'

Dockerfile

@@ -0,0 +1,32 @@
+FROM ubuntu:eoan AS compiler-build
+
+RUN apt-get update && \
+    dpkg --add-architecture i386 && \
+    apt-get install -y gcc \
+                       gcc-multilib \
+                       make \
+                       cmake \
+                       git \
+                       python3.8
+
+WORKDIR /home
+ADD . /home/pawn
+COPY ./build.sh /home/build.sh
+RUN mkdir build
+RUN /home/build.sh
+WORKDIR /home/build
+
+CMD ["/bin/bash"]
+
+FROM ubuntu:eoan AS compiler
+RUN mkdir /home/compiler
+RUN mkdir /home/build
+WORKDIR /home/build
+COPY --from=compiler-build /home/build/pawncc .
+COPY --from=compiler-build /home/build/pawnruns .
+COPY --from=compiler-build /home/build/pawndisasm .
+COPY --from=compiler-build /home/build/libpawnc.so .
+WORKDIR /home
+ADD ./copy.sh /home
+
+CMD /bin/bash

build.sh

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+cd build && \
+cmake ../pawn/source/compiler \
+-DCMAKE_C_FLAGS=-m32 \
+-DCMAKE_BUILD_TYPE=Release && \
+make

copy.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+cp -r /home/build /home/compiler

docker-compose.yaml

@@ -0,0 +1,10 @@
+version: '3.7'
+
+services:
+  compiler:
+    build: .
+    stdin_open: true
+    tty: true
+    restart: 'no'
+    volumes:
+      - ${PWD}/compiler:/home/compiler

readme.md

@@ -86,10 +86,12 @@ Parallel installation is supported.
 
 If you are a [sampctl][sampctl] user, you are already using this compiler!
 
-### Build From Source
+### Building from Source
 
-If you are interested in contributing or just using a specific version, check
-out [this page][build_source] for instructions for compiling for your platform.
+If you are interested in contributing then please first read
+[this document][contributing] and ensure you have discussed your proposed
+changes before writing any code. Check out [this page][build_source] for
+instructions for compiling for your platform.
 
 ## Background
 
@@ -121,5 +123,7 @@ seems to be based on an older release of Pawn.
 [artifacts]:
   https://ci.appveyor.com/project/Southclaws/compiler/branch/master/artifacts
 [compat]: https://github.com/pawn-lang/compiler/wiki/Compatibility-mode
-[sampctl]: http://bit.ly/sampctl
+[sampctl]: https://github.com/Southclaws/sampctl
+[contributing]:
+  https://github.com/pawn-lang/compiler/tree/master/.github/CONTRIBUTING.md
 [build_source]: https://github.com/pawn-lang/compiler/wiki/Building-From-Source

source/amx/CMakeLists.txt

@@ -1,6 +1,8 @@
 project(pawnamx C)
 cmake_minimum_required(VERSION 2.8)
 
+set_property(GLOBAL PROPERTY USE_FOLDERS ON)
+
 # check for optional include files
 include(CheckIncludeFile)
 check_include_file("unistd.h" HAVE_UNISTD_H)