Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"removed" missing "comms_restored" option in provider schemas #690

Closed
davenguyen opened this issue Sep 2, 2021 · 1 comment · Fixed by #699
Closed

"removed" missing "comms_restored" option in provider schemas #690

davenguyen opened this issue Sep 2, 2021 · 1 comment · Fixed by #699
Assignees
Labels
bug Something isn't working State Machine Changes in the vehicle state events and state machine diagram
Milestone

Comments

@davenguyen
Copy link

davenguyen commented Sep 2, 2021

Describe the bug
The "status_changes" provider schema is missing the "comms_restored" event type under the "removed" vehicle_state. It's missing on both 1.0.0 and 1.1.0 schema.

I assume since the state machine diagram has "Unknown can go to any state with event_type comms_restored, located, unspecified", this should be included for "removed" as well.

To Reproduce

See schemas for each version:

Expected behavior

comms_restored should be added to "event_types" -> "contains" -> "enum" under removed.

Additional context

None.

@schnuerle schnuerle added bug Something isn't working State Machine Changes in the vehicle state events and state machine diagram labels Sep 3, 2021
@schnuerle schnuerle added this to the 1.2.0 milestone Sep 3, 2021
@schnuerle schnuerle self-assigned this Sep 16, 2021
@schnuerle schnuerle modified the milestones: 1.2.0, 1.1.1 Sep 20, 2021
@schnuerle schnuerle linked a pull request Sep 20, 2021 that will close this issue
@schnuerle
Copy link
Member

Fixed for 1.1.1 with PR #699. Please review @davenguyen for accuracy. I will create the release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants