-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Curb Objects #126
Draft
jacobmalleau
wants to merge
22
commits into
dev
Choose a base branch
from
jacobmalleau-creatingcurbobject
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bb4b9e1
Update README.md
jacobmalleau b33b523
Update Curb Object Attributes
jacobmalleau 6adbdbb
Added object basic properties, well known types, TOC
schnuerle 5041899
Add Objects to Zones and Spaces
jacobmalleau 117e43b
Added more and sorted object types
jacobmalleau c43e9de
Add objects to events
jacobmalleau dbf8bdf
Adding Objects to Metrics
jacobmalleau 864dbe3
Address Some Comments from Working Group Meeting
jacobmalleau 7bb63d1
Adding Point GeoJSON
schnuerle bed2a3d
Add object owner, external id/URL
schnuerle 0f054ff
Added object endpoints
schnuerle 5be93ae
Added Object Type Attributes
schnuerle 56cf45a
Add operator field & space/zone endpoint parameters
schnuerle baacbda
Merged object attributes to types
schnuerle bc18f7a
Rearranged required object fields
schnuerle 0f540e0
Added object shape
schnuerle 399956b
Removed duplicate geometry field
schnuerle 3df4f23
Update README.md
jacobmalleau dce17a8
Added Objects to Event Endpoints
jacobmalleau 97b8ac2
Added Objects to Metric Endpoints
jacobmalleau bc27f1d
Noted Objects are like Spaces, no previous IDs needed for updates
jacobmalleau c8f5dc0
Updates to Curb Objects Based on October 29th CDS Meeting
jacobmalleau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be for multiple IDs, so
curb_object_id
? One event could use a meter and an EV charger and a locker, for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could list multiple IDs here, although maybe it should only be what the true source of the event is (if you plug into the charger, book the locker, or pay at the meter)? I think leaving it as one option could be cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this can stay as one single ID per event. If multiple objects need to record simultaneous events at a zone, then they each get their own event. So this is fine as is.