Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Active/Current View Paradigm #16

Open
pshriwise opened this issue Apr 17, 2019 · 0 comments
Open

New Active/Current View Paradigm #16

pshriwise opened this issue Apr 17, 2019 · 0 comments

Comments

@pshriwise
Copy link
Collaborator

Now that we're using matplotlib as a viewing backend and generating images based on id/property maps, many of the view updates which used to require calls into OpenMC can now be done by modifying the data we're storing in place in the GUI.

While this creates an opportunity to make the GUI run more smoothly, it also blurs the lines between the "active view" (the updated, but unapplied view) and the "current view" (the view on screen) in the plotting model. Where before, any change to the current view would require plot regeneration we can now limit this to parameters being passed to the get_id_map/get_property_map function and do all other updates on the current set of data stored on the model. We now need to distinguish between these items to do it properly throughout the model, view, and controller. As part of this effort, I'm going to attempt to only enable the Apply Changes buttons when new id/property map generation is necessary to update the view to ensure this isn't being hit unnecessarily by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant