Skip to content

Release of version 0.14.0 #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 6, 2023
Merged

Release of version 0.14.0 #2754

merged 6 commits into from
Nov 6, 2023

Conversation

@paulromano
Copy link
Contributor

Description

This PR makes the final changes for a 0.14.0 release:

  • Adds release notes
  • Add some missing .. versionadded:: directives
  • Fixes a broken latexpdf build for our documentation
  • Adds a missing virtual destrutor on the BoundaryCondition class that was causing a warning with clang

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from pshriwise November 3, 2023 22:51
pshriwise
pshriwise requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion for you to consider regarding additional info on the new ordering of data returned from Mesh.vertices/centroids in a release note. Otherwise, I'm happy w/ it! 🚀

pshriwise
pshriwise approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pshriwise pshriwise merged commit fa23301 into openmc-dev:develop Nov 6, 2023
@paulromano paulromano deleted the release-0.14.0 branch November 7, 2023 18:34
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
@paulromano @church89
Release of version 0.14.0 (openmc-dev#2754)
ef92891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pshriwise pshriwise pshriwise approved these changes

@drewejohnson drewejohnson Awaiting requested review from drewejohnson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulromano @pshriwise