Skip to content

fix olh mobile nav dropdown #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephDriver wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix olh mobile nav dropdown #5307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b353b
fix: #5123 olh press nav classname typo
StephDriver May 11, 2026
3a03394
fix: #5123 olh dropdown css
StephDriver May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/themes/OLH/assets/scss/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,13 @@ button.list-group-item-danger.active:focus {
float:right;
}

.is-drilldown{overflow-y: scroll}
.is-drilldown {
overflow-y: scroll;
.is-dropdown-submenu-parent,
.is-drilldown-submenu-parent {
position: static;
}
}

.homepage-element-about {
margin-top: 30px;
Expand Down
6 changes: 3 additions & 3 deletions src/themes/OLH/templates/press/nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<li><a href="/">{% trans 'Home' %}</a></li>
{% for item in navigation_items %}
{% if item.has_sub_nav %}
<li class=".is-dropdown-submenu-parent"><a href="#"
<li class="is-dropdown-submenu-parent"><a href="#"
data-options="is_hover:true; hover_timeout:5000">{{ item.link_name }}</a>
<ul class="menu vertical medium-horizontal">
{% if item.link %}<li><a href="{{ item.url }}">{{ item.link_name }}</a></li>{% endif %}
Expand All @@ -27,7 +27,7 @@
<li><a href="{% url 'press_conferences' %}">{% trans 'Conferences' %}</a></li>
{% endif %}
{% if request.press.enable_preprints %}
<li class=".is-dropdown-submenu-parent"><a href="#"
<li class="is-dropdown-submenu-parent"><a href="#"
data-options="is_hover:true; hover_timeout:5000">{% trans 'Repositories' %}</a>
<ul class="menu vertical medium-horizontal">
{% for repo in request.press.live_repositories %}
Expand All @@ -40,7 +40,7 @@
<li><a href="{% url 'editorial_team' %}">{% trans 'Editorial Team' %}</a></li>{% endif %}
<li><a href="{% url 'contact' %}">{% trans 'Contact' %}</a></li>
{% hook 'nav_block' %}
<li class=".is-dropdown-submenu-parent show-for-small-only">
<li class="is-dropdown-submenu-parent show-for-small-only">
<a href="#" data-options="is_hover:true; hover_timeout:5000">{% trans 'Account' %}</a>
<ul class="menu vertical medium-horizontal">
{% if request.user.is_authenticated %}
Expand Down
Loading