More clarity a11y tweaks

[StephDriver]

continues with clarity a11y testing and tweaking.

[ajrbyers]

@StephDriver this will need to be rebased.

[StephDriver]

Edit - Midnight work to be moved to after 1.9, so moving remaining midnight work out of task list.

Pages / areas Reviewed and updated (work continuing from #5000)

• article
• article modals
• homepage
• contact
• articles
• search - needs a11y updates to full-text-search pages #4964 once that's closed.
• press home
• press journals
• journal nav
• journal header
• journal footer
• press nav
• press header
• press footer
• carousel
• issues
• issue
• contact
• special collections
• news index
• news items
• public profiles
• check all above in terms of colours for each of the new colour schemes
  • cardinal
  • evergreen
  • ocean
• check mobile versions of the above

To Fix:

• article authors listed with bullet points - will be fixed when Fixed a display bug where the article title was not displayed due to numerous authors #4960 from release branch is merged into master.
• lists - awaiting a11y clean - update loops to non-visible list syntax and style #4905 to be included on this branch - it is in master.
• clean template cherrypicking - look at Developer docs for image sizing and cropping #4844
• check for missing clean templates (where it falls back to other themes)
• public_profile page - affiliations etc. info that comes under the H1 of the person's name. Currently <br/> separated text.
• article page card no-image as on-error class, is it behaving as expected? some text is then black not white.
• contrast for article text on top of banner images (for carousel and for article pages)
• transition point for narrow/wide nav to be the same as narrow/wide article layout (i.e. no sidebar until wide)
• image alignment on cards on homepage - they seem to be taking the column alignment rather than being aligned within the card itself:

Midnight

• check all pages as above
• consider 'dark mode logo' options
• dyslexia theme (swap to dark)
• blockquotes - left border make visible
• figure captions - table captions
• special collection - bullet list on right, the bullets are aligning to the bottom of the item not the top.