-
Notifications
You must be signed in to change notification settings - Fork 84
Fixed a display bug where the article title was not displayed due to numerous authors #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think displaying the email addresses is making the problem worse than it needs to be. some emails are incredibly verbose and I think using an icon/buttin is fine, plus the email can still be copied. I think the usability factor is how easy it is to read the person name and affiliation, rather than being able to read the email address. It also makes things less busy when using the sidebar

(note how this author has 3 URLS underlying, making it difficult to know what each does, unless you hover and inspect the URL below)
vs
We could also use a similar icon to link out to public profile, similar to how we do for ORCID.
As for the scroll bar on the OLH theme, I personally hate it but I'm unable to provide a better solution, other than moving the author metadata to the sidebar as suggested OR using an expansible list.
Co-authored-by: Steph Driver <5330770+StephDriver@users.noreply.github.com>
80a20e0 to
4db8479
Compare
|
Thanks @mauromsl --please read the updated description above for an explanation of updates. |
mauromsl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mauromsl --please read the updated description above for an explanation of updates.
Lovely stuff, improved useability, more clarity, consistency across themes... 🥇 :
Fixes #4952.
I've decided on a minimal intervention here, which is to make the author list scrollable when it is taller than 6 rem.After a discussion we have decided to move the full author details to the sidebar for all three themes. It was already there for Material, so this is a change for Clean and OLH.
A compact list of authors still appears in the hero / title box.
I've moved the links away from the text and toward icons, to avoid distracting too much. I tried to make them accessible using the new patterns established by Steph. To make this play nicely your new list styling in #4905, @StephDriver, I have pulled foward some of your CSS and named you as co-author on that commit. I moved it to common, since it is identical as far as I could tell, where you had it in the 3 themes. I also modified it slightly to add an option for "and", and to wipe out unwanted artefacts from the theme styling.
I have also moved CRediT roles into the same display area, since it did not make sense to me to list authors again for this information. They have their own icon with a link out to the NISO CRediT site.