IE11 can't interpret window.ActiveXObject correctly anymore #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in IE11 it is not possible to use window.ActiveXObject for checking for IE anymore (see http://msdn.microsoft.com/en-us/library/ie/dn423948%28v=vs.85%29.aspx ), it is only possible to use a try-catch instead.
bkiselka
pushed a commit
to bkiselka/ol2
that referenced
this pull request
Mar 25, 2014
I think I experience the same problem of issue openlayers#1177 As an example I modified the GetFeatureInfo example injecting the corrupt data that cause the error in IE11. Just click in the map. Obviously the not valid HTML5 is can't be read with DomParser() in IE11. One solution is pull request openlayers#1285 Another solution may be to check the INFO_FORMAT and do not call var features = this.format.read(doc); if it is text/html or text/plain (i.e. not a GML) as in showInfo() just the text is used (no GML features): document.getElementById('responseText').innerHTML = evt.text;
This was referenced Mar 25, 2014
|
An alternative solution would be to use this check instead of the exception approach: this.supportActiveX = then window.ActiveXObject can be replaced with this.supportActiveX in the expressions. |
|
I like that approach @szekerest. Would you be willing to create a pull request? |
|
@ahocevar pull request sent |
|
Fixed with #1439 |
bwalding
referenced
this pull request
in codehaus/mapbuilder
May 27, 2015
bkiselka
pushed a commit
to bkiselka/ol2
that referenced
this pull request
Nov 25, 2016
I think I experience the same problem of issue openlayers#1177 As an example I modified the GetFeatureInfo example injecting the corrupt data that cause the error in IE11. Just click in the map. Obviously the not valid HTML5 is can't be read with DomParser() in IE11. One solution is pull request openlayers#1285 Another solution may be to check the INFO_FORMAT and do not call var features = this.format.read(doc); if it is text/html or text/plain (i.e. not a GML) as in showInfo() just the text is used (no GML features): document.getElementById('responseText').innerHTML = evt.text;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in IE11 it is not possible to use window.ActiveXObject for checking for IE anymore (see http://msdn.microsoft.com/en-us/library/ie/dn423948%28v=vs.85%29.aspx ), it is only possible to use a try-catch instead.
May be the intention of pull request #1210