Allow disabling kruise-daemon-config namespace #143
Conversation
…ests to a separate file & make DaemonSet namespace name configurable Signed-off-by: Marino Borges <omarinoborges@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @marinoborges! It looks like this is your first PR to openkruise/charts 🎉 |
Signed-off-by: Marino Borges <omarinoborges@gmail.com>
| kind: DaemonSet | ||
| metadata: | ||
| name: kruise-daemon | ||
| namespace: {{ .Values.installation.daemonSet.namespace }} |
There was a problem hiding this comment.
the daemonset installation namespace is not the same as the configuration namespace, plz keep the namespace as is (.Values.installation.namespace)
There was a problem hiding this comment.
I get what you're saying but it's still unclear to me the purpose of a separate namespace. What is it for?
| annotations: | ||
| {{ toYaml .Values.serviceAccount.annotations | indent 4 }} | ||
| {{- end }} | ||
| namespace: {{ .Values.installation.daemonSet.namespace }} |
There was a problem hiding this comment.
the daemonset installation namespace is not the same as the configuration namespace, plz keep the namespace as is (.Values.installation.namespace)
| namespace: kruise-system | ||
| createNamespace: true | ||
| daemonSet: | ||
| namespace: kruise-daemon-config |
There was a problem hiding this comment.
we should rename namespace to config-namespace so as to avoid the confusion between installation namespace
There was a problem hiding this comment.
i agree but this will probably turn it into a major release, right?
There was a problem hiding this comment.
it used to save the pull secrets used by imagepulljobs, so it is not the same as the daemon installation namespace
Signed-off-by: Marino Borges <omarinoborges@gmail.com>
Also move DaemonSet manifests to a separate file
&
Make DaemonSet namespace name configurable
Resolve #134
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.