-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1327 - Adds OpenJS Github Continuity Policy #1348
Conversation
Fixed linter complaints. Signed-off-by: Benjamin Sternthal <ben@devpatch.com>
Given that option 3 is to opt-out I can't see a reason not to include existing projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The policy is simple, clear and provides good options for the projects 👍
Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Benjamin Sternthal <ben@devpatch.com>
Removed hard line breaks per feedback. Signed-off-by: Benjamin Sternthal <ben@devpatch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great policy
This PR adds the Github Continuity Policy discussed in #1327. Note there was discussion around the applicability of the policy to existing projects with at least one person suggesting that the policy only be enforced for new projects.
I would recommend making the policy retro-active and applicable to all projects, primarily for the following two reasons: