Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: jax-smfsb: A python library for stochastic systems biology modelling and inference #7491

Open
editorialbot opened this issue Nov 18, 2024 · 7 comments
Assignees
Labels
Makefile Python review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @darrenjw (Darren James Wilkinson)
Repository: https://github.com/darrenjw/jax-smfsb
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @jromanowska
Reviewers: @antoineruzette, @cthoyt
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/714db278d0aae77efbf0fe7a98679890"><img src="https://joss.theoj.org/papers/714db278d0aae77efbf0fe7a98679890/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/714db278d0aae77efbf0fe7a98679890/status.svg)](https://joss.theoj.org/papers/714db278d0aae77efbf0fe7a98679890)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@antoineruzette & @cthoyt, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jromanowska know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@antoineruzette, please create your checklist typing: @editorialbot generate my checklist

@cthoyt, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1538.3 files/s, 130522.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          40            659           1136           1707
TeX                              1             25              0            130
reStructuredText                 4            147            306            114
Markdown                         2             35              0             67
make                             3             27             11             42
TOML                             1              4              0             29
YAML                             2             11             20             27
-------------------------------------------------------------------------------
SUM:                            53            908           1473           2116
-------------------------------------------------------------------------------

Commit count by author:

   121	Darren Wilkinson
     1	Charles Tapley Hoyt

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 690

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1111/j.1467-9868.2009.00736.x is OK
- 10.1016/j.cpc.2022.108527 is OK
- 10.1093/bioinformatics/btn051 is OK
- 10.1098/rsfs.2011.0047 is OK
- 10.1007/s11222-011-9288-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1093/bioinformatics/btab669 is OK
- 10.15252/msb.20199110 is OK
- 10.1088/1742-5468/ac3ae9 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1098/rsif.2008.0172 is OK
- 10.1093/bioinformatics/btac770 is OK
- 10.1038/nrg2509 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: On Neural Differential Equations
- No DOI given, and none found for title: An overview of the Scala programming language
- No DOI given, and none found for title: Python 3 Reference Manual
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: scala-smfsb
- No DOI given, and none found for title: python-smfsb

❌ MISSING DOIs

- 10.1201/9781351000918 may be a valid DOI for title: Stochastic Modelling for Systems Biology, third ed...
- 10.32614/cran.package.smfsb may be a valid DOI for title: smfsb: Stochastic Modelling for Systems Biology

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jromanowska
Copy link

👋🏼 @darrenjw, @antoineruzette, @cthoyt, this is the review thread for the paper. All of our communications will happen here from now on.

As a reviewer, the first step is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#7491 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time.

I encourage you to over-communicate and let everyone know that you're on the task every now and then, instead of waiting several weeks to collect all your comments, questions, or suggestions.

Please feel free to ping me (@jromanowska) if you have any questions/concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Makefile Python review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

2 participants