-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: EKF_CAL: Extended Kalman Filter-based Calibration and Localization #7292
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Five most similar historical JOSS papers: imucal - A Python library to calibrate 6 DOF IMUs AixCaliBuHA: Automated calibration of building and HVAC systems SLAM Toolbox: SLAM for the dynamic world Pose2Sim: An open-source Python package for multiview markerless kinematics GeoBO: Python package for Multi-Objective Bayesian Optimisation and Joint Inversion in Geosciences |
Hi @JHartzer, we will use this pre-review issue to find an editor and reviewers, and resolve any issues. Although I can see that your software package meets most of our requirements (documentation, installation instructions, etc.), I'm not sure about a test suite. At minimum, we need instructions on manually testing the full functionality of the software; normally, we want to see—and reviewers will request—an automated test suite for unit and functional testing. (And at best, hooked into continuous integration.) |
Hello @kyleniemeyer! Thank you for the initial feedback. I do have a test suite (that is not yet automated) for code testing and coverage. I've updated the main README and documentation landing to hopefully make that a little more clear. I can also take an action to work on a CI pipeline. As far as reviewer suggestions, here is a list of possibilities from similar authors and a keyword search:
|
@editorialbot invite @pdebuyl as editor |
Invitation to edit this submission sent! |
Submitting author: @JHartzer (Jacob Hartzer)
Repository: https://github.com/unmannedlab/ekf_cal/
Branch with paper.md (empty if default branch):
Version: 0.5
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @JHartzer. Currently, there isn't a JOSS editor assigned to your paper.
@JHartzer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: