Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: reflectorch: a deep learning package for X-ray and neutron reflectometry #7089

Open
editorialbot opened this issue Aug 8, 2024 · 18 comments
Assignees
Labels
Dockerfile pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 8, 2024

Submitting author: @valentinsingularity (Valentin Munteanu)
Repository: https://github.com/schreiber-lab/reflectorch
Branch with paper.md (empty if default branch):
Version: v1.2.1
Editor: @likeajumprope
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ec70c26c483ce71520590229050c40eb"><img src="https://joss.theoj.org/papers/ec70c26c483ce71520590229050c40eb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ec70c26c483ce71520590229050c40eb/status.svg)](https://joss.theoj.org/papers/ec70c26c483ce71520590229050c40eb)

Author instructions

Thanks for submitting your paper to JOSS @valentinsingularity. Currently, there isn't a JOSS editor assigned to your paper.

@valentinsingularity if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Aug 8, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/jphysrad:01950001107030700 is OK
- 10.1107/s1600576724002115 is OK
- 10.1107/S160057752300749X is OK
- 10.1107/S1600576722002230 is OK
- 10.1107/S1600576724001171 is OK
- 10.1107/S1600576722006653 is OK
- 10.1107/S1600576718017296 is OK
- 10.5281/ZENODO.4329338 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.26 s (1458.8 files/s, 272812.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            47           7973            191          21802
YAML                           149           1071           1834          12941
Python                          89           2076           1069           7105
CSS                             12            809            113           2904
PO File                         45           1007              0           2284
JavaScript                      16            197            299           1279
Jupyter Notebook                 4              0           4484            428
Markdown                         4             67              0            181
TeX                              1              8              0            101
CSV                              1              0              0             98
TOML                             1              5              0             53
SVG                              6              0              1             30
Dockerfile                       1              4              0              9
reStructuredText                 1              1             75              2
-------------------------------------------------------------------------------
SUM:                           377          13218           8066          49217
-------------------------------------------------------------------------------

Commit count by author:

   267	Valentin Munteanu
   169	Vladimir Starostin
    16	valentinsingularity
     7	StarostinV
     7	cvoelt
     3	Anastasia Ragulskaya
     1	constantin

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1244

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Author (Dmitry Lapkin) is missing affiliation.

@valentinsingularity
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @valentinsingularity, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@valentinsingularity
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

xrdfit: A Python package for fitting synchrotron X-ray diffraction spectra
Submitting author: @merrygoat
Handling editor: @jgostick (Active)
Reviewers: @KedoKudo, @mikapfl
Similarity score: 0.7135

Reel1.0 - A visualization tool for evaluating powder diffraction refinements
Submitting author: @fgjorup
Handling editor: @rkurchin (Active)
Reviewers: @cmbiwer, @mikapfl
Similarity score: 0.7117

xtal2png: A Python package for representing crystal structure as PNG files
Submitting author: @sgbaird
Handling editor: @rkurchin (Active)
Reviewers: @dandavies99, @PeterKraus
Similarity score: 0.7100

islatu: A Python package for the reduction of reflectometry data
Submitting author: @RBrearton
Handling editor: @jgostick (Active)
Reviewers: @andyfaff, @daguiam
Similarity score: 0.6983

Lightshow: a Python package for generating computational x-ray absorption spectroscopy input files
Submitting author: @matthewcarbone
Handling editor: @ppxasjsm (Active)
Reviewers: @maurov, @larsenkg
Similarity score: 0.6949

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

crvernon commented Aug 8, 2024

@editorialbot invite @likeajumprope as editor

👋 @likeajumprope this sounds like one you may wish to edit. Can you take this one on?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

Just following back up on this one @likeajumprope ...

👋 @likeajumprope this sounds like one you may wish to edit. Can you take this one on?

@likeajumprope
Copy link

Just following back up on this one @likeajumprope ...

👋 @likeajumprope this sounds like one you may wish to edit. Can you take this one on?

Ah sure - apologies I have been on summer leave

@likeajumprope
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @likeajumprope is now the editor

@crvernon
Copy link

No problem @likeajumprope and thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dockerfile pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants