Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Staring down direct infusion metabolomics datasets with MeDUSA #6892

Open
editorialbot opened this issue Jun 14, 2024 · 28 comments
Assignees
Labels
Dockerfile pre-review R Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 14, 2024

Submitting author: @laura-hetzel (Laura Ann Hetzel)
Repository: https://github.com/laura-hetzel/MeDUSA
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @diazrenata
Reviewers: Pending
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/95fd8471eaa8ddcb50beadccffcf8167"><img src="https://joss.theoj.org/papers/95fd8471eaa8ddcb50beadccffcf8167/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/95fd8471eaa8ddcb50beadccffcf8167/status.svg)](https://joss.theoj.org/papers/95fd8471eaa8ddcb50beadccffcf8167)

Author instructions

Thanks for submitting your paper to JOSS @laura-hetzel. Currently, there isn't a JOSS editor assigned to your paper.

@laura-hetzel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Jun 14, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

No paper file path

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.49 s (42.4 files/s, 103731.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              9              1              0         114453
XML                              6              0              0          34900
R                               40            532           1417           2650
Markdown                         1             18              0             48
TeX                              1              6              0             48
Bourne Shell                     4             11             16             37
Dockerfile                       1              7             14             27
Python                           1              4              2             10
-------------------------------------------------------------------------------
SUM:                            63            579           1449         152173
-------------------------------------------------------------------------------

Commit count by author:

   114	Pascal
    72	NotEric
    26	Laura Hetzel
    14	Eman-Mu
    11	David Rasp
    10	klabla
     8	Merys Valdez
     8	Pascal Maas
     4	Ahmed Ali
     2	Alida Kindt-Dunjko
     1	StatisticsValdez

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Failed to find a paper file in https://github.com/laura-hetzel/MeDUSA

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Paper file not found.

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@TheFollyLlama
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 18, 2024
@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/anie.201709719 is OK
- 10.1038/nprot.2016.156 is OK
- 10.1021/ac051437y is OK
- 10.1093/nar/gkab382 is OK
- 10.1038/s41598-024-55356-3 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.3109/03014460.2013.807878. is INVALID

@TheFollyLlama
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3109/03014460.2013.807878 is OK
- 10.1002/anie.201709719 is OK
- 10.1038/nprot.2016.156 is OK
- 10.1021/ac051437y is OK
- 10.1093/nar/gkab382 is OK
- 10.1038/s41598-024-55356-3 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @zhubonan as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@zhubonan this work may be somewhat outside of your usual domain, but I was wondering if you are familiar with the techniques employed and therefore able to handle it regardless. Thanks anyway.

@zhubonan
Copy link

@Kevin-Mattheus-Moerman Sorry, this is a bit far from my domain...

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @diazrenata as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diazrenata
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diazrenata is now the editor

@diazrenata
Copy link

diazrenata commented Aug 5, 2024

Hi @laura-hetzel! I'll be editing this submission. Have you had a chance to look at the reviewer application and identify any potential reviewers?

@TheFollyLlama
Copy link

@diazrenata
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=1.41 s (44.6 files/s, 107463.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              9              1              0         114453
XML                              5              0              0          32339
R                               40            527           1451           2652
YAML                             2              3             15             50
Markdown                         1             18              0             48
TeX                              1              6              0             48
Bourne Shell                     4             11             16             37
Dockerfile                       1              6             14             28
-------------------------------------------------------------------------------
SUM:                            63            572           1496         149655
-------------------------------------------------------------------------------

Commit count by author:

   114	Pascal
    83	NotEric
    26	Laura Hetzel
    14	Eman-Mu
    11	David Rasp
    10	klabla
     8	Merys Valdez
     8	Pascal Maas
     4	Ahmed Ali
     2	Alida Kindt-Dunjko
     2	Eric Hetzel
     1	StatisticsValdez

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 958

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@diazrenata
Copy link

@laura-hetzel and @TheFollyLlama - on looking over the repo, my first question is about a general description of the software. Usually this information is in the README - e.g. what the software does, how to install it and use it, any dependencies, and examples. Could you add a page like this? It would make it much easier for reviewers and potential users of the software.

Also - is @laura-hetzel or @TheFollyLlama the author for correspondence?

@TheFollyLlama
Copy link

hi @diazrenata. I've updated the README.
The R requirements are in the R package directory . Easiest way to install and use is via the dockerhub image

The corresponding author is @ahmed-ali9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dockerfile pre-review R Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

5 participants