Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Optim: An optimization package for Julia #611

Closed
whedon opened this issue Mar 9, 2018 · 13 comments
Closed

[PRE REVIEW]: Optim: An optimization package for Julia #611

whedon opened this issue Mar 9, 2018 · 13 comments

Comments

@whedon
Copy link

whedon commented Mar 9, 2018

Submitting author: @anriseth (Asbjørn Nilsen Riseth)
Repository: https://github.com/JuliaNLSolvers/Optim.jl
Version: v0.14.0
Editor: @labarba
Reviewer: @ahwillia

Author instructions

Thanks for submitting your paper to JOSS @anriseth. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@anriseth if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 9, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Mar 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@arfon
Copy link
Member

arfon commented Mar 9, 2018

👋 @labarba - the submitting author suggested you as the handling editor.

@whedon
Copy link
Author

whedon commented Mar 9, 2018

@anriseth
Copy link

Of the existing reviewers, may I suggest @vchuravy and @ahwillia? They both know Julia very well, and machine learning backgrounds may be helpful in terms of optimization.
Another person in the Julia optimization community that has a an appropriate background is @abelsiqueira.

@anriseth
Copy link

The article proof looks fine. I'll also cc @pkofod

@ahwillia
Copy link

I'm happy to review.

I've used this package extensively in the past and have had mostly good experiences. I haven't used it in the past year or so.

@abelsiqueira
Copy link

I can review as well.

@labarba
Copy link
Member

labarba commented Mar 12, 2018

@whedon assign @ahwillia as reviewer

@whedon
Copy link
Author

whedon commented Mar 12, 2018

OK, the reviewer is @ahwillia

@labarba
Copy link
Member

labarba commented Mar 12, 2018

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Mar 12, 2018

OK, I've started the review over in #615. Feel free to close this issue now!

@labarba
Copy link
Member

labarba commented Mar 12, 2018

Thank you for agreeing to review, @ahwillia — Please go over to the REVIEW issue now, where you can use comments to communicate with the author and editors as you complete your review.
#615

@anriseth — In your paper, I do miss some brief note about existing software providing similar functionality (in the same or other programming language). We don't have a novelty requirement, but we do want to see other software mentioned or cited, as appropriate.

@labarba labarba closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants