Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: The pyJSON Schema Loader and JSON Editor #6090

Closed
editorialbot opened this issue Nov 24, 2023 · 18 comments
Closed

[PRE REVIEW]: The pyJSON Schema Loader and JSON Editor #6090

editorialbot opened this issue Nov 24, 2023 · 18 comments
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @nplathe (Nick Plathe)
Repository: https://github.com/nplathe/pyJSON-Schema-Loader-and-JSON-Editor/
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9c4f2565eb971f8dd8960caaa7bd0d56"><img src="https://joss.theoj.org/papers/9c4f2565eb971f8dd8960caaa7bd0d56/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9c4f2565eb971f8dd8960caaa7bd0d56/status.svg)](https://joss.theoj.org/papers/9c4f2565eb971f8dd8960caaa7bd0d56)

Author instructions

Thanks for submitting your paper to JOSS @nplathe. Currently, there isn't a JOSS editor assigned to your paper.

@nplathe if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 24, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (745.3 files/s, 127541.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            494            965           2147
Qt                               2              0              0            693
Markdown                         7            119              0            380
JSON                             4              0              0            361
TeX                              1             18              2            162
YAML                             3              2              4             74
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            32            645            979           3852
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 2067

@editorialbot
Copy link
Collaborator Author

@danielskatz
Copy link

👋 @nplathe - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it, in this case found a tab character that violate indentation while scanning a plain scalar at line 9 column 12 Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@nplathe
Copy link

nplathe commented Nov 27, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@nplathe
Copy link

nplathe commented Nov 27, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SampleDB: A sample and measurement metadata database
Submitting author: @FlorianRhiem
Handling editor: @arfon (Active)
Reviewers: @stuartcampbell, @dvanic
Similarity score: 0.7953

Ipyannotator: the infinitely hackable annotation framework
Submitting author: @itepifanio
Handling editor: @danielskatz (Active)
Reviewers: @csadorf, @matthewfeickert
Similarity score: 0.7939

phyphy: Python package for facilitating the execution and parsing of HyPhy standard analyses
Submitting author: @sjspielman
Handling editor: @mgymrek (Retired)
Reviewers: @luizirber
Similarity score: 0.7928

yaml2sbml: Human-readable and -writable specification of ODE models and their conversion to SBML
Submitting author: @jvanhoefer
Handling editor: @kellyrowland (Active)
Reviewers: @SirSharpest, @marouenbg
Similarity score: 0.7903

DataLad: distributed system for joint management of code, data, and their relationship
Submitting author: @yarikoptic
Handling editor: @arokem (Retired)
Reviewers: @szorowi1, @jkanche
Similarity score: 0.7880

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.1162/dint_a_00084 is OK
- 10.17192/bfdm.2023.2.8570 is OK
- 10.18154/RWTH-2020-11948 is OK
- 10.1007/978-3-319-11955-7_71 is OK
- 10.12688/f1000research.110875.2 is OK
- 10.5334/dsj-2021-008 is OK

MISSING DOIs

- 10.17487/rfc7158 may be a valid DOI for title: The JavaScript Object Notation (JSON) Data Interchange Format 

INVALID DOIs

- None

@danielskatz
Copy link

@nplathe - thanks for your submission. As it's not clear to me that this is research software as defined by JOSS, the editors will now discuss this. You should hear back in a week or so.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Nov 29, 2023
@danielskatz
Copy link

I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission is not research software as defined by JOSS. This does not mean that it is not software that is useful in research, but just that JOSS does not consider it in scope for review as research software. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

@danielskatz
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants